third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp - Issue 1773813007: blink: Rename modules/ method to prefix with get when they collide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp

Issue 1773813007: blink: Rename modules/ method to prefix with get when they collide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clash-modules: rebase-fixes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptFunction.h ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp

index 3e6b096628fe99c28b470774a54557e46f4e6e30..41d5aac5845b515c65dcae0af2d422b5c29af2f2 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp

@@ -20,7 +20,7 @@ void ScriptFunction::callCallback(const v8::FunctionCallbackInfo<v8::Value>& arg

{

ASSERT(args.Data()->IsExternal());

ScriptFunction* scriptFunction = static_cast<ScriptFunction*>(v8::Local<v8::External>::Cast(args.Data())->Value());

- ScriptValue result = scriptFunction->call(ScriptValue(scriptFunction->scriptState(), args[0]));

+ ScriptValue result = scriptFunction->call(ScriptValue(scriptFunction->getScriptState(), args[0]));

v8SetReturnValue(args, result.v8Value());

}