Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Issue 1773813002: S390: Fixed condition code handling on FP->INT and FP rounding in simulator. (Closed)

Created:
4 years, 9 months ago by bcleung
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://github.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fixed condition code handling on FP->INT and FP rounding in simulator. The below instructions were fixed so that the produced condition codes in simulator matched behaviour in native s390 CPUs: CFDBR CGDBR CGEBR CFEBR CLFDBR CLGDBR CLGEBR Also implemented the CLFEBR instruction in s390 simulator. (Copypaste of 1763663003, which was pointing at wrong branch - should be master, not lkgr) R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,joransiu@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com,jyan@ca.ibm.com BUG= Committed: https://crrev.com/2fdc0ae3aa6fbab76e0ac2663be7998fe99d75dc Cr-Commit-Position: refs/heads/master@{#34598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -37 lines) Patch
M src/s390/simulator-s390.h View 1 chunk +60 lines, -0 lines 0 comments Download
M src/s390/simulator-s390.cc View 7 chunks +16 lines, -37 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
bcleung
4 years, 9 months ago (2016-03-07 21:03:20 UTC) #4
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-07 21:41:13 UTC) #5
JoranSiu
lgtm
4 years, 9 months ago (2016-03-08 18:28:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773813002/1
4 years, 9 months ago (2016-03-08 18:49:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 19:15:13 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 19:16:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fdc0ae3aa6fbab76e0ac2663be7998fe99d75dc
Cr-Commit-Position: refs/heads/master@{#34598}

Powered by Google App Engine
This is Rietveld 408576698