S390: Fixed condition code handling on FP->INT and FP rounding in simulator.

src/s390/simulator-s390.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdarg.h>
 #include <stdlib.h>
 #include <cmath>
 
 #if V8_TARGET_ARCH_S390
 
@@ skipping 2957 matching lines @@
 
 void Simulator::DecodeFourByteFloatingPointIntConversion(Instruction* instr) {
   Opcode op = instr->S390OpcodeValue();
   switch (op) {
     case CDLFBR:
     case CDLGBR:
     case CELGBR:
     case CLFDBR:
     case CLGDBR:
     case CELFBR:
-    case CLGEBR: {
+    case CLGEBR:
+    case CLFEBR: {
       RREInstruction* rreInstr = reinterpret_cast<RREInstruction*>(instr);
       int r1 = rreInstr->R1Value();
       int r2 = rreInstr->R2Value();
       if (op == CDLFBR) {
         uint32_t r2_val = get_low_register<uint32_t>(r2);
         double r1_val = static_cast<double>(r2_val);
         set_d_register_from_double(r1, r1_val);
       } else if (op == CELFBR) {
         uint32_t r2_val = get_low_register<uint32_t>(r2);
         float r1_val = static_cast<float>(r2_val);
         set_d_register_from_float32(r1, r1_val);
       } else if (op == CDLGBR) {
         uint64_t r2_val = get_register(r2);
         double r1_val = static_cast<double>(r2_val);
         set_d_register_from_double(r1, r1_val);
       } else if (op == CELGBR) {
         uint64_t r2_val = get_register(r2);
         float r1_val = static_cast<float>(r2_val);
         set_d_register_from_float32(r1, r1_val);
       } else if (op == CLFDBR) {
         double r2_val = get_double_from_d_register(r2);
         uint32_t r1_val = static_cast<uint32_t>(r2_val);
         set_low_register(r1, r1_val);
-        SetS390ConditionCode<double>(r2_val, 0);
+        SetS390ConvertConditionCode<double>(r2_val, r1_val, UINT32_MAX);
+      } else if (op == CLFEBR) {
+        float r2_val = get_float32_from_d_register(r2);
+        uint32_t r1_val = static_cast<uint32_t>(r2_val);
+        set_low_register(r1, r1_val);
+        SetS390ConvertConditionCode<double>(r2_val, r1_val, UINT32_MAX);
       } else if (op == CLGDBR) {
         double r2_val = get_double_from_d_register(r2);
         uint64_t r1_val = static_cast<uint64_t>(r2_val);
         set_register(r1, r1_val);
-        SetS390ConditionCode<double>(r2_val, 0);
+        SetS390ConvertConditionCode<double>(r2_val, r1_val, UINT64_MAX);
       } else if (op == CLGEBR) {
         float r2_val = get_float32_from_d_register(r2);
         uint64_t r1_val = static_cast<uint64_t>(r2_val);
         set_register(r1, r1_val);
-        SetS390ConditionCode<double>(r2_val, 0);
+        SetS390ConvertConditionCode<double>(r2_val, r1_val, UINT64_MAX);
       }
       break;
     }
     default:
       UNREACHABLE();
   }
 }
 
 void Simulator::DecodeFourByteFloatingPointRound(Instruction* instr) {
   Opcode op = instr->S390OpcodeValue();
   RREInstruction* rreInstr = reinterpret_cast<RREInstruction*>(instr);
   int r1 = rreInstr->R1Value();
   int r2 = rreInstr->R2Value();
   double r2_val = get_double_from_d_register(r2);
   float r2_fval = get_float32_from_d_register(r2);
 
   switch (op) {
     case CFDBR: {
       int mask_val = rreInstr->M3Value();
       int32_t r1_val = 0;
 
-      if (r2_val == 0.0)
-        condition_reg_ = 8;
-      else if (r2_val < 0.0)
-        condition_reg_ = 4;
-      else if (r2_val > 0.0)
-        condition_reg_ = 2;
-      else
-        condition_reg_ = 1;
+      SetS390RoundConditionCode(r2_val, INT32_MAX, INT32_MIN);
 
       switch (mask_val) {
         case CURRENT_ROUNDING_MODE:
         case ROUND_TO_PREPARE_FOR_SHORTER_PRECISION: {
           r1_val = static_cast<int32_t>(r2_val);
           break;
         }
         case ROUND_TO_NEAREST_WITH_TIES_AWAY_FROM_0: {
           double ceil_val = std::ceil(r2_val);
           double floor_val = std::floor(r2_val);
@@ skipping 60 matching lines @@
         default:
           UNREACHABLE();
       }
       set_low_register(r1, r1_val);
       break;
     }
     case CGDBR: {
       int mask_val = rreInstr->M3Value();
       int64_t r1_val = 0;
 
-      if (r2_val == 0.0)
-        condition_reg_ = 8;
-      else if (r2_val < 0.0)
-        condition_reg_ = 4;
-      else if (r2_val > 0.0)
-        condition_reg_ = 2;
-      else
-        condition_reg_ = 1;
+      SetS390RoundConditionCode(r2_val, INT64_MAX, INT64_MIN);
 
       switch (mask_val) {
         case CURRENT_ROUNDING_MODE:
         case ROUND_TO_NEAREST_WITH_TIES_AWAY_FROM_0:
         case ROUND_TO_PREPARE_FOR_SHORTER_PRECISION: {
           UNIMPLEMENTED();
           break;
         }
         case ROUND_TO_NEAREST_WITH_TIES_TO_EVEN: {
           double ceil_val = std::ceil(r2_val);
@@ skipping 28 matching lines @@
         default:
           UNREACHABLE();
       }
       set_register(r1, r1_val);
       break;
     }
     case CGEBR: {
       int mask_val = rreInstr->M3Value();
       int64_t r1_val = 0;
 
-      if (r2_fval == 0.0)
-        condition_reg_ = 8;
-      else if (r2_fval < 0.0)
-        condition_reg_ = 4;
-      else if (r2_fval > 0.0)
-        condition_reg_ = 2;
-      else
-        condition_reg_ = 1;
+      SetS390RoundConditionCode(r2_fval, INT64_MAX, INT64_MIN);
 
       switch (mask_val) {
         case CURRENT_ROUNDING_MODE:
         case ROUND_TO_NEAREST_WITH_TIES_AWAY_FROM_0:
         case ROUND_TO_PREPARE_FOR_SHORTER_PRECISION: {
           UNIMPLEMENTED();
           break;
         }
         case ROUND_TO_NEAREST_WITH_TIES_TO_EVEN: {
           float ceil_val = std::ceil(r2_fval);
@@ skipping 28 matching lines @@
         default:
           UNREACHABLE();
       }
       set_register(r1, r1_val);
       break;
     }
     case CFEBR: {
       int mask_val = rreInstr->M3Value();
       int32_t r1_val = 0;
 
-      if (r2_fval == 0.0)
-        condition_reg_ = 8;
-      else if (r2_fval < 0.0)
-        condition_reg_ = 4;
-      else if (r2_fval > 0.0)
-        condition_reg_ = 2;
-      else
-        condition_reg_ = 1;
+      SetS390RoundConditionCode(r2_fval, INT32_MAX, INT32_MIN);
 
       switch (mask_val) {
         case CURRENT_ROUNDING_MODE:
         case ROUND_TO_PREPARE_FOR_SHORTER_PRECISION: {
           r1_val = static_cast<int32_t>(r2_fval);
           break;
         }
         case ROUND_TO_NEAREST_WITH_TIES_AWAY_FROM_0: {
           float ceil_val = std::ceil(r2_fval);
           float floor_val = std::floor(r2_fval);
@@ skipping 228 matching lines @@
         UNREACHABLE();
       }
       break;
     }
     case CDLFBR:
     case CDLGBR:
     case CELGBR:
     case CLFDBR:
     case CELFBR:
     case CLGDBR:
-    case CLGEBR: {
+    case CLGEBR:
+    case CLFEBR: {
       DecodeFourByteFloatingPointIntConversion(instr);
       break;
     }
     case TMLL: {
       RIInstruction* riinst = reinterpret_cast<RIInstruction*>(instr);
       int r1 = riinst->R1Value();
       int mask = riinst->I2Value() & 0x0000FFFF;
       if (mask == 0) {
         condition_reg_ = 0x0;
         break;
@@ skipping 1502 matching lines @@
   uintptr_t address = *stack_slot;
   set_register(sp, current_sp + sizeof(uintptr_t));
   return address;
 }
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // USE_SIMULATOR
 #endif  // V8_TARGET_ARCH_S390