Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3007)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: core/src/fpdfdoc/doc_form.cpp

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/src/fpdfapi/fpdf_parser/fpdf_parser_objects_unittest.cpp ('K') | « core/src/fpdfdoc/doc_action.cpp ('k') | core/src/fpdfdoc/doc_link.cpp » ('j') | core/src/fpdfdoc/doc_tagged.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/src/fpdfdoc/doc_form.cpp
diff --git a/core/src/fpdfdoc/doc_form.cpp b/core/src/fpdfdoc/doc_form.cpp
index 684d9122ad91969b52346dc84da1ef9370fdfba4..d161ed4be3e1c1616e64e035bc699c1595753e92 100644
--- a/core/src/fpdfdoc/doc_form.cpp
+++ b/core/src/fpdfdoc/doc_form.cpp
@@ -4,6 +4,8 @@
// Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
+#include <vector>
Tom Sepez 2016/03/08 19:27:05 Hmm. What does this fix?
dsinclair 2016/03/08 21:08:01 bool CPDF_InterForm::ResetForm(const std::vector<C
Tom Sepez 2016/03/08 21:18:09 Acknowledged.
+
#include "core/include/fpdfdoc/fpdf_doc.h"
#include "core/src/fpdfdoc/doc_utils.h"
#include "third_party/base/stl_util.h"
@@ -384,6 +386,7 @@ static FX_BOOL RetrieveSpecificFont(uint8_t charSet,
lf.lfCharSet = charSet;
lf.lfPitchAndFamily = pitchAndFamily;
if (pcsFontName) {
+ // TODO(dsinclair): Should this be snprintf?
Tom Sepez 2016/03/08 19:27:04 you mean strncpy?
dsinclair 2016/03/08 21:08:01 Was going by: core/src/fpdfdoc/doc_form.cpp:390:
strcpy(lf.lfFaceName, pcsFontName);
}
return RetrieveSpecificFont(lf);
« core/src/fpdfapi/fpdf_parser/fpdf_parser_objects_unittest.cpp ('K') | « core/src/fpdfdoc/doc_action.cpp ('k') | core/src/fpdfdoc/doc_link.cpp » ('j') | core/src/fpdfdoc/doc_tagged.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698