Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1773593003: Revert of [key-accumulator] Starting to reimplement the key-accumulator (Closed)

Created:
4 years, 9 months ago by Camillo Bruni
Modified:
4 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [key-accumulator] Starting to reimplement the key-accumulator (patchset #14 id:260001 of https://codereview.chromium.org/1707743002/ ) Reason for revert: gcmole failure https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/8598 Original issue's description: > [key-accumulator] Starting to reimplement the key-accumulator > > Introducing the KeyAccumulator accidentally removed some crucial fast-paths. > This CL starts rewriting the KeyAccumulator, step-by-step introducing the > special cases again. > > BUG=chromium:545503, v8:4758 > LOG=y > > Committed: https://crrev.com/9c61327ecb2ee41f34232632e0cac93202bae6b7 > Cr-Commit-Position: refs/heads/master@{#34532} TBR=verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:545503, v8:4758 Committed: https://crrev.com/18db9af622f3cdde8e0b1a97323aca3a5fa2ca81 Cr-Commit-Position: refs/heads/master@{#34537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+500 lines, -796 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M src/elements.h View 2 chunks +1 line, -14 lines 0 comments Download
M src/elements.cc View 8 chunks +54 lines, -156 lines 0 comments Download
A src/key-accumulator.h View 1 chunk +94 lines, -0 lines 0 comments Download
A src/key-accumulator.cc View 1 chunk +324 lines, -0 lines 0 comments Download
D src/keys.h View 1 chunk +0 lines, -125 lines 0 comments Download
D src/keys.cc View 1 chunk +0 lines, -426 lines 0 comments Download
M src/objects.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/objects.cc View 11 chunks +14 lines, -10 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-forin.cc View 3 chunks +7 lines, -18 lines 0 comments Download
M test/mjsunit/for-in.js View 2 chunks +1 line, -31 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Camillo Bruni
Created Revert of [key-accumulator] Starting to reimplement the key-accumulator
4 years, 9 months ago (2016-03-07 12:44:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773593003/1
4 years, 9 months ago (2016-03-07 12:44:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 12:44:33 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 12:46:06 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18db9af622f3cdde8e0b1a97323aca3a5fa2ca81
Cr-Commit-Position: refs/heads/master@{#34537}

Powered by Google App Engine
This is Rietveld 408576698