Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1773593002: [compiler] Remove support for concurrent OSR. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, ulan, Hannes Payer (out of office), Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove support for concurrent OSR. R=yangguo@chromium.org Committed: https://crrev.com/2669224274a9b6bf1e619556d1b259970a9116bc Cr-Commit-Position: refs/heads/master@{#34572}

Patch Set 1 #

Patch Set 2 : Remove flag from tests. #

Patch Set 3 : Ported to all architectures. #

Patch Set 4 : Fix release builds. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -525 lines) Patch
M src/arm/builtins-arm.cc View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
M src/builtins.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler.h View 4 chunks +2 lines, -14 lines 0 comments Download
M src/compiler.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 2 chunks +2 lines, -8 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 chunks +0 lines, -7 lines 0 comments Download
M src/full-codegen/full-codegen.h View 2 chunks +1 line, -12 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 3 chunks +5 lines, -11 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 3 chunks +5 lines, -11 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 3 3 chunks +4 lines, -7 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 2 chunks +4 lines, -11 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 2 chunks +4 lines, -10 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/optimizing-compile-dispatcher.h View 4 chunks +0 lines, -34 lines 0 comments Download
M src/optimizing-compile-dispatcher.cc View 8 chunks +11 lines, -133 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +2 lines, -44 lines 0 comments Download
M src/s390/builtins-s390.cc View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
M test/mjsunit/assert-opt-and-deopt.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/optimized-for-in.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress-sync-optimized-lists.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-2618.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-343609.js View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 1773663003 Patch 1

Messages

Total messages: 8 (2 generated)
Michael Starzinger
Ports not done yet, but ready for first round of comments.
4 years, 9 months ago (2016-03-07 12:18:04 UTC) #1
Michael Starzinger
Ports done. Ready for final review.
4 years, 9 months ago (2016-03-07 15:30:14 UTC) #2
Yang
LGTM. Looks like you got everything. I can't think of any other code that needs ...
4 years, 9 months ago (2016-03-08 05:56:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773593002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773593002/60001
4 years, 9 months ago (2016-03-08 08:59:29 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-08 09:01:36 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 09:02:53 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/2669224274a9b6bf1e619556d1b259970a9116bc
Cr-Commit-Position: refs/heads/master@{#34572}

Powered by Google App Engine
This is Rietveld 408576698