Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1773663003: [compiler] Slightly change API to finalize compile jobs. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-remove-concurrent-osr
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Slightly change API to finalize compile jobs. This changes the compiler API that finalizes a previously queued optimization job on the main thread, to not deal with code objects directly. This is in sync with the rest of the API now. R=yangguo@chromium.org Committed: https://crrev.com/cabe6844c29206349ba8a14907a64de27916d549 Cr-Commit-Position: refs/heads/master@{#34577}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Fix think'o. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M src/compiler.h View 1 2 chunks +3 lines, -5 lines 0 comments Download
M src/compiler.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M src/optimizing-compile-dispatcher.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-07 17:50:36 UTC) #1
Yang
On 2016/03/07 17:50:36, Michael Starzinger wrote: lgtm.
4 years, 9 months ago (2016-03-07 19:38:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773663003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773663003/40001
4 years, 9 months ago (2016-03-08 10:07:44 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-08 10:09:25 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 10:11:01 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cabe6844c29206349ba8a14907a64de27916d549
Cr-Commit-Position: refs/heads/master@{#34577}

Powered by Google App Engine
This is Rietveld 408576698