Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1773503002: Shortcut ImageResource::canRender() (Closed)

Created:
4 years, 9 months ago by davve
Modified:
4 years, 9 months ago
Reviewers:
fs
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, loading-reviews+fetch_chromium.org, rwlbuis, tyoshino+watch_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shortcut ImageResource::canRender() Move the little work ImageResource::canRender() does out of fetch/ and into the respective call sites. A small step towards getting rid of ImageResource::imageSize() and limiting ImageResource to fetch related functionality. It's assumed that ImageResource::image() never returns the nullptr and that !errorOccurred() implies the an image or the nullImage if no image is available. BUG=581357 Committed: https://crrev.com/8cc8a0e9395a2fc70d1a048e7e2862a9081cc70d Cr-Commit-Position: refs/heads/master@{#379549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773503002/1
4 years, 9 months ago (2016-03-07 10:00:37 UTC) #2
davve
4 years, 9 months ago (2016-03-07 12:07:41 UTC) #4
fs
LGTM Maybe mention in the description about the "assumption" made (!errorOccurred() => ImageResource::image() != nullptr) ...
4 years, 9 months ago (2016-03-07 12:18:58 UTC) #5
davve
On 2016/03/07 12:18:58, fs wrote: > LGTM > > Maybe mention in the description about ...
4 years, 9 months ago (2016-03-07 12:33:50 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 12:46:10 UTC) #8
fs
On 2016/03/07 at 12:33:50, davve wrote: > On 2016/03/07 12:18:58, fs wrote: > > LGTM ...
4 years, 9 months ago (2016-03-07 12:57:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773503002/1
4 years, 9 months ago (2016-03-07 13:49:04 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 13:53:45 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 13:55:41 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cc8a0e9395a2fc70d1a048e7e2862a9081cc70d
Cr-Commit-Position: refs/heads/master@{#379549}

Powered by Google App Engine
This is Rietveld 408576698