Shortcut ImageResource::canRender()

Shortcut ImageResource::canRender()

Move the little work ImageResource::canRender() does out of fetch/ and
into the respective call sites. A small step towards getting rid of
ImageResource::imageSize() and limiting ImageResource to fetch related
functionality.

It's assumed that ImageResource::image() never returns the nullptr and
that !errorOccurred() implies the an image or the nullImage if no
image is available.

BUG=581357
Committed: https://crrev.com/8cc8a0e9395a2fc70d1a048e7e2862a9081cc70d
Cr-Commit-Position: refs/heads/master@{#379549}

[davve, 2016-03-07 10:00:21]

The CQ bit was checked by davve@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 10:00:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1773503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1773503002/1

[davve, 2016-03-07 12:07:41]

davve@opera.com changed reviewers:
+ fs@opera.com

[fs, 2016-03-07 12:18:58]

LGTM

Maybe mention in the description about the "assumption" made (!errorOccurred()
=>  ImageResource::image() != nullptr) since that was sort of papered over
previously (ImageResource::imageSize doing a null-check in the "preamble".)

[davve, 2016-03-07 12:33:50]

On 2016/03/07 12:18:58, fs wrote:
> LGTM
> 
> Maybe mention in the description about the "assumption" made (!errorOccurred()
> =>  ImageResource::image() != nullptr) since that was sort of papered over
> previously (ImageResource::imageSize doing a null-check in the "preamble".)

Hm, ImageResource::image() never returns the nullptr AFAICS (there might be some
nullptr checks that might be redundant over this). It might return the nullImage
though (or the brokenImage if errorOccurred()). I'll add something to the
description.

[commit-bot: I haz the power, 2016-03-07 12:46:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 12:46:10]

Dry run: This issue passed the CQ dry run.

[fs, 2016-03-07 12:57:25]

On 2016/03/07 at 12:33:50, davve wrote:
> On 2016/03/07 12:18:58, fs wrote:
> > LGTM
> > 
> > Maybe mention in the description about the "assumption" made
(!errorOccurred()
> > =>  ImageResource::image() != nullptr) since that was sort of papered over
> > previously (ImageResource::imageSize doing a null-check in the "preamble".)
> 
> Hm, ImageResource::image() never returns the nullptr AFAICS (there might be
some nullptr checks that might be redundant over this). It might return the
nullImage though (or the brokenImage if errorOccurred()). I'll add something to
the description.

Yes, that's what I meant by "assumption", sorry for being unclear.

[davve, 2016-03-07 13:48:35]

Description was changed from

==========
Shortcut ImageResource::canRender()

Move the little work ImageResource::canRender() does out of fetch/ and
into the respective call sites. A small step towards getting rid of
ImageResource::imageSize() and limiting ImageResource to fetch related
functionality.

BUG=581357
==========

to

==========
Shortcut ImageResource::canRender()

Move the little work ImageResource::canRender() does out of fetch/ and
into the respective call sites. A small step towards getting rid of
ImageResource::imageSize() and limiting ImageResource to fetch related
functionality.

It's assumed that ImageResource::image() never returns the nullptr and
that !errorOccurred() implies the an image or the nullImage if no
image is available.

BUG=581357
==========

[davve, 2016-03-07 13:48:57]

The CQ bit was checked by davve@opera.com

[commit-bot: I haz the power, 2016-03-07 13:49:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1773503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1773503002/1

[commit-bot: I haz the power, 2016-03-07 13:53:44]

Description was changed from

==========
Shortcut ImageResource::canRender()

Move the little work ImageResource::canRender() does out of fetch/ and
into the respective call sites. A small step towards getting rid of
ImageResource::imageSize() and limiting ImageResource to fetch related
functionality.

It's assumed that ImageResource::image() never returns the nullptr and
that !errorOccurred() implies the an image or the nullImage if no
image is available.

BUG=581357
==========

to

==========
Shortcut ImageResource::canRender()

Move the little work ImageResource::canRender() does out of fetch/ and
into the respective call sites. A small step towards getting rid of
ImageResource::imageSize() and limiting ImageResource to fetch related
functionality.

It's assumed that ImageResource::image() never returns the nullptr and
that !errorOccurred() implies the an image or the nullImage if no
image is available.

BUG=581357
==========

[commit-bot: I haz the power, 2016-03-07 13:53:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-07 13:55:39]

Description was changed from

==========
Shortcut ImageResource::canRender()

Move the little work ImageResource::canRender() does out of fetch/ and
into the respective call sites. A small step towards getting rid of
ImageResource::imageSize() and limiting ImageResource to fetch related
functionality.

It's assumed that ImageResource::image() never returns the nullptr and
that !errorOccurred() implies the an image or the nullImage if no
image is available.

BUG=581357
==========

to

==========
Shortcut ImageResource::canRender()

Move the little work ImageResource::canRender() does out of fetch/ and
into the respective call sites. A small step towards getting rid of
ImageResource::imageSize() and limiting ImageResource to fetch related
functionality.

It's assumed that ImageResource::image() never returns the nullptr and
that !errorOccurred() implies the an image or the nullImage if no
image is available.

BUG=581357

Committed: https://crrev.com/8cc8a0e9395a2fc70d1a048e7e2862a9081cc70d
Cr-Commit-Position: refs/heads/master@{#379549}
==========

[commit-bot: I haz the power, 2016-03-07 13:55:41]

Patchset 1 (id:??) landed as
https://crrev.com/8cc8a0e9395a2fc70d1a048e7e2862a9081cc70d
Cr-Commit-Position: refs/heads/master@{#379549}