third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp - Issue 1773503002: Shortcut ImageResource::canRender()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp

Issue 1773503002: Shortcut ImageResource::canRender() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp

diff --git a/third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp b/third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp

index 0eeb5bb14664187b58e582eeb290f1cd9947ccf1..e42aefb82e73ac564c804e62a3afb9a0b371d455 100644

--- a/third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp

+++ b/third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp

@@ -80,7 +80,7 @@ PassRefPtrWillBeRawPtr<CSSValue> StyleFetchedImageSet::computedCSSValue() const

bool StyleFetchedImageSet::canRender() const

{

- return m_bestFitImage->canRender();

+ return !m_bestFitImage->errorOccurred() && !m_bestFitImage->image()->isNull();

}

bool StyleFetchedImageSet::isLoaded() const

« no previous file with comments | « third_party/WebKit/Source/core/style/StyleFetchedImage.cpp ('k') | no next file » | no next file with comments »