Issue 177343005: Use SkLayerDrawLooper::Builder to construct SkLayerDrawLooper.

Issue 177343005: Use SkLayerDrawLooper::Builder to construct SkLayerDrawLooper. (Closed)

Created:
6 years, 10 months ago by Dominik Grewe

Modified:
6 years, 10 months ago

Reviewers:
danakj

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use SkLayerDrawLooper::Builder to construct SkLayerDrawLooper. The addLayer() methods of SkLayerDrawLooper will soon be removed. This CL updates all uses of those methods with the corresponding methods in SkLayerDrawLooper::Builder. BUG=skia:2141 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253100

Patch Set 1 #

Total comments: 2

Patch Set 2 : looperBuilder -> looper_builder #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	ui/gfx/skia_util.cc	View	1	2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

danakj

LGTM https://codereview.chromium.org/177343005/diff/1/ui/gfx/skia_util.cc File ui/gfx/skia_util.cc (right): https://codereview.chromium.org/177343005/diff/1/ui/gfx/skia_util.cc#newcode107 ui/gfx/skia_util.cc:107: SkLayerDrawLooper::Builder looperBuilder; looper_builder

6 years, 10 months ago (2014-02-24 18:05:32 UTC) #2

Dominik Grewe

Thanks. https://codereview.chromium.org/177343005/diff/1/ui/gfx/skia_util.cc File ui/gfx/skia_util.cc (right): https://codereview.chromium.org/177343005/diff/1/ui/gfx/skia_util.cc#newcode107 ui/gfx/skia_util.cc:107: SkLayerDrawLooper::Builder looperBuilder; On 2014/02/24 18:05:33, danakj wrote: > ...

6 years, 10 months ago (2014-02-24 18:18:12 UTC) #3