Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: mojo/public/cpp/system/handle.h

Issue 1773403006: [mojo-sdk] Replace assert() usage in bindings with DCHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/system/data_pipe.h ('k') | mojo/public/cpp/system/message_pipe.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/system/handle.h
diff --git a/mojo/public/cpp/system/handle.h b/mojo/public/cpp/system/handle.h
index 989d0c540504edecd81f29d3c2a461e4029c1cbb..4df86af2d34532f2280b8b6a44295da4e899616c 100644
--- a/mojo/public/cpp/system/handle.h
+++ b/mojo/public/cpp/system/handle.h
@@ -5,11 +5,11 @@
#ifndef MOJO_PUBLIC_CPP_SYSTEM_HANDLE_H_
#define MOJO_PUBLIC_CPP_SYSTEM_HANDLE_H_
-#include <assert.h>
#include <stdint.h>
#include <limits>
#include "base/compiler_specific.h"
+#include "base/logging.h"
#include "base/macros.h"
#include "base/move.h"
#include "mojo/public/c/system/functions.h"
@@ -127,7 +127,7 @@ class ScopedHandleBase {
return;
MojoResult result = MojoClose(handle_.value());
ALLOW_UNUSED_LOCAL(result);
- assert(result == MOJO_RESULT_OK);
+ DCHECK_EQ(MOJO_RESULT_OK, result);
}
HandleType handle_;
« no previous file with comments | « mojo/public/cpp/system/data_pipe.h ('k') | mojo/public/cpp/system/message_pipe.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698