Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2208)

Unified Diff: mojo/public/cpp/system/data_pipe.h

Issue 1773403006: [mojo-sdk] Replace assert() usage in bindings with DCHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/system/buffer.h ('k') | mojo/public/cpp/system/handle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/system/data_pipe.h
diff --git a/mojo/public/cpp/system/data_pipe.h b/mojo/public/cpp/system/data_pipe.h
index e4c46dc29fbb814f656a6a703bb21f3ef191df16..c5f97075ebc8f7bb104350fba56cced03a5a5353 100644
--- a/mojo/public/cpp/system/data_pipe.h
+++ b/mojo/public/cpp/system/data_pipe.h
@@ -12,10 +12,10 @@
#ifndef MOJO_PUBLIC_CPP_SYSTEM_DATA_PIPE_H_
#define MOJO_PUBLIC_CPP_SYSTEM_DATA_PIPE_H_
-#include <assert.h>
#include <stdint.h>
#include "base/compiler_specific.h"
+#include "base/logging.h"
#include "mojo/public/c/system/data_pipe.h"
#include "mojo/public/cpp/system/handle.h"
#include "mojo/public/cpp/system/macros.h"
@@ -64,8 +64,8 @@ inline MojoResult CreateDataPipe(
const MojoCreateDataPipeOptions* options,
ScopedDataPipeProducerHandle* data_pipe_producer,
ScopedDataPipeConsumerHandle* data_pipe_consumer) {
- assert(data_pipe_producer);
- assert(data_pipe_consumer);
+ DCHECK(data_pipe_producer);
+ DCHECK(data_pipe_consumer);
DataPipeProducerHandle producer_handle;
DataPipeConsumerHandle consumer_handle;
MojoResult rv = MojoCreateDataPipe(options,
@@ -146,14 +146,14 @@ inline DataPipe::DataPipe() {
MojoResult result =
CreateDataPipe(nullptr, &producer_handle, &consumer_handle);
ALLOW_UNUSED_LOCAL(result);
- assert(result == MOJO_RESULT_OK);
+ DCHECK_EQ(MOJO_RESULT_OK, result);
}
inline DataPipe::DataPipe(const MojoCreateDataPipeOptions& options) {
MojoResult result =
CreateDataPipe(&options, &producer_handle, &consumer_handle);
ALLOW_UNUSED_LOCAL(result);
- assert(result == MOJO_RESULT_OK);
+ DCHECK_EQ(MOJO_RESULT_OK, result);
}
inline DataPipe::~DataPipe() {
« no previous file with comments | « mojo/public/cpp/system/buffer.h ('k') | mojo/public/cpp/system/handle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698