Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1773403006: [mojo-sdk] Replace assert() usage in bindings with DCHECK. (Closed)

Created:
4 years, 9 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 9 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-sdk] Replace assert() usage in bindings with DCHECK. BUG=None Committed: https://crrev.com/30051152d1372b479c8b5392b65fdd5e86a302fd Cr-Commit-Position: refs/heads/master@{#380357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -30 lines) Patch
M mojo/public/cpp/bindings/lib/shared_data.h View 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/strong_binding.h View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/public/cpp/system/buffer.h View 6 chunks +7 lines, -7 lines 0 comments Download
M mojo/public/cpp/system/data_pipe.h View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/public/cpp/system/handle.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/system/message_pipe.h View 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Anand Mistry (off Chromium)
4 years, 9 months ago (2016-03-10 04:30:44 UTC) #2
yzshen1
lgtm
4 years, 9 months ago (2016-03-10 04:36:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773403006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773403006/1
4 years, 9 months ago (2016-03-10 04:37:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/194408)
4 years, 9 months ago (2016-03-10 05:47:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1773403006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1773403006/1
4 years, 9 months ago (2016-03-10 05:48:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 06:21:36 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 06:23:52 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/30051152d1372b479c8b5392b65fdd5e86a302fd
Cr-Commit-Position: refs/heads/master@{#380357}

Powered by Google App Engine
This is Rietveld 408576698