third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h - Issue 1773403002: Update SVG text layout to use shaped glyph data & go fast (O(n^2)->O(n))

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

Issue 1773403002: Update SVG text layout to use shaped glyph data & go fast (O(n^2)->O(n)) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1773353003

Patch Set: Minor cleanup of comments and tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/text/lengthAdjust-text-metrics-expected.txt ('k') | third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/SVGTextMetricsBuilder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h b/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

index 17e743a1e6e6511aa5a7e2817d7719ea6bcedb9f..dc0bdd6481f7fb0f85c0d06cf11584f2ba8b0e79 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

@@ -40,7 +40,6 @@ public:

SVGTextMetrics(MetricsType);

SVGTextMetrics(LineLayoutSVGInlineText, unsigned length, float width);

- static SVGTextMetrics measureCharacterRange(LineLayoutSVGInlineText, unsigned position, unsigned length, TextDirection);

static TextRun constructTextRun(LineLayoutSVGInlineText, unsigned position, unsigned length, TextDirection);

bool isEmpty() const { return !m_width && !m_height && m_length <= 1; }