third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp - Issue 1773403002: Update SVG text layout to use shaped glyph data & go fast (O(n^2)->O(n))

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp

Issue 1773403002: Update SVG text layout to use shaped glyph data & go fast (O(n^2)->O(n)) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1773353003

Patch Set: Minor cleanup of comments and tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h ('k') | third_party/WebKit/Source/core/layout/svg/SVGTextMetricsBuilder.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/SVGTextMetricsBuilder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp b/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp

index ef7723369f058d73a7baa6ccc55cb92dfb5f844b..a5ed6ed8471a28fac7f0e401134d694feb6fa1b6 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp

@@ -84,12 +84,6 @@ TextRun SVGTextMetrics::constructTextRun(LineLayoutSVGInlineText textLayoutItem,

return run;

}

-SVGTextMetrics SVGTextMetrics::measureCharacterRange(LineLayoutSVGInlineText textLayoutItem, unsigned position, unsigned length, TextDirection textDirection)

- ASSERT(textLayoutItem);

- return SVGTextMetrics(textLayoutItem, constructTextRun(textLayoutItem, position, length, textDirection));

SVGTextMetrics::SVGTextMetrics(LineLayoutSVGInlineText textLayoutItem, unsigned length, float width)

{

ASSERT(textLayoutItem);