Issue 17734002: [telemetry] Small fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17734002: [telemetry] Small fixes. (Closed)

Created:
7 years, 6 months ago by dtu

Modified:
7 years, 6 months ago

Reviewers:
tonyg, nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[telemetry] Small fixes. Fix for crash when page has no archive path. Was crashing when trying to do os.path.isfile(None) Fix license header in one file. Remove empty directory if we removed .pyc files from it. BUG=None. TEST=None. R=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208561

Patch Set 1 #

Patch Set 2 : Add a (c) somewhere. #

Patch Set 3 : If we removed .pyc files, check if we can remove the entire directory. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -15 lines)			Patch
M	tools/telemetry/build/update_docs.py	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/telemetry/docs/telemetry.core.platform.profiler.perf_profiler.html	View		1 chunk	+6 lines, -5 lines	0 comments	Download
M	tools/telemetry/docs/telemetry.page.page_test_runner.html	View		1 chunk	+1 line, -8 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/inspector_network.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/page_runner.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dtu

Uhm, seems like different versions/platforms are outputting slightly different docs, which causes the churn.

7 years, 6 months ago (2013-06-25 20:21:36 UTC) #1

tonyg

On 2013/06/25 20:44:22, Dave Tu wrote: > Tacked on some doc fixes :) lgtm

7 years, 6 months ago (2013-06-25 20:55:06 UTC) #4

dtu

7 years, 6 months ago (2013-06-25 21:59:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r208561 (presubmit successful).

Expand Messages | Collapse Messages