Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 17734002: [telemetry] Small fixes. (Closed)

Created:
7 years, 6 months ago by dtu
Modified:
7 years, 6 months ago
Reviewers:
tonyg, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[telemetry] Small fixes. Fix for crash when page has no archive path. Was crashing when trying to do os.path.isfile(None) Fix license header in one file. Remove empty directory if we removed .pyc files from it. BUG=None. TEST=None. R=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208561

Patch Set 1 #

Patch Set 2 : Add a (c) somewhere. #

Patch Set 3 : If we removed .pyc files, check if we can remove the entire directory. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M tools/telemetry/build/update_docs.py View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tools/telemetry/docs/telemetry.core.platform.profiler.perf_profiler.html View 1 chunk +6 lines, -5 lines 0 comments Download
M tools/telemetry/docs/telemetry.page.page_test_runner.html View 1 chunk +1 line, -8 lines 0 comments Download
M tools/telemetry/telemetry/core/chrome/inspector_network.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_runner.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dtu
Uhm, seems like different versions/platforms are outputting slightly different docs, which causes the churn.
7 years, 6 months ago (2013-06-25 20:21:36 UTC) #1
tonyg
lgtm with a better patch description
7 years, 6 months ago (2013-06-25 20:31:59 UTC) #2
dtu
Tacked on some doc fixes :)
7 years, 6 months ago (2013-06-25 20:44:22 UTC) #3
tonyg
On 2013/06/25 20:44:22, Dave Tu wrote: > Tacked on some doc fixes :) lgtm
7 years, 6 months ago (2013-06-25 20:55:06 UTC) #4
dtu
7 years, 6 months ago (2013-06-25 21:59:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r208561 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698