Change tests to use test.py's test_controller.js, cleanup in browser_controller

Change tests to use test.py's test_controller.js, cleanup in browser_controller

This change makes all remaining tests use test.py's test_controller.js:
We have our own way of testing using test.py and that might change any time.
It's therefore not wise to rely on functionality in the unittest framework. If
we kept test_controller.js in the unittest package, we'd need to make a breaking
change whenever we change the behavior of test_controller.js. So this file was
forked into tools/testing/dart/test_controller.js.

After this, all our tests will use tools/testing/dart/test_controller.js. It is
therefore no longer necessary for the browser_controller to support the old
mechanism of posting back results. By removing this legacy code, we can ensure,
that the driving page of browser_controller will only react on valid messages
which were ment for it.
Context:
Some tests (e.g. dromaeo) might use postMessage internally, maybe even for
testing that postMessage is working. But the driving window should only react
on valid messages ment for it, ignoring any other messages.

R=blois@google.com, efortuna@google.com, ricow@google.com, whesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33365

[kustermann, 2014-03-05 10:43:27]

@Emily/Pete: I'm not sure if these tests rely on any specific functionality in
unittest/test_controller.js.

See also the discussion on:
https://codereview.chromium.org/178223008/

https://codereview.chromium.org/177333004/diff/1/dart/tools/testing/dart/brow...
File dart/tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/177333004/diff/1/dart/tools/testing/dart/brow...
dart/tools/testing/dart/browser_controller.dart:1439: }
Maybe we should remove the "if" here to support empty messages?

[ricow1, 2014-03-05 11:45:53]

Browser controller changes: LGTM
I would like input from Pete/Emily on the rest

https://codereview.chromium.org/177333004/diff/1/dart/tools/testing/dart/brow...
File dart/tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/177333004/diff/1/dart/tools/testing/dart/brow...
dart/tools/testing/dart/browser_controller.dart:1422: // Only if the JSON was
valid, we'll post it back.
only if the JSON is contains all the required parameters we will handle it and
post it back to the test controller

https://codereview.chromium.org/177333004/diff/1/dart/tools/testing/dart/brow...
dart/tools/testing/dart/browser_controller.dart:1439: }
On 2014/03/05 10:43:28, kustermann wrote:
> Maybe we should remove the "if" here to support empty messages?

yes - I think we should

[Bill Hesse, 2014-03-05 13:19:51]

lgtm

[blois, 2014-03-05 16:37:32]

On 2014/03/05 13:19:51, Bill Hesse wrote:
> lgtm

lgtm as well. It may also be helpful to pull some of the code from tools/testing
into a 'dart testing' package which either isn't published or is published but
with no guarantees about breaking changes.

[kustermann, 2014-03-05 17:39:59]

On 2014/03/05 16:37:32, blois wrote:
> On 2014/03/05 13:19:51, Bill Hesse wrote:
> > lgtm
> 
> lgtm as well. It may also be helpful to pull some of the code from
tools/testing
> into a 'dart testing' package which either isn't published or is published but
> with no guarantees about breaking changes.

Same idea here. But we'll need to so some cleanups before we can split it up.
Furthermore we've to decide how we handle test.py/test.dart when it uses
packages (checking in a snapshot, a dart2dart compiled file [once dart2dart is
good enough]) [we probably don't want everyone on our team to have a "packages"
directory with symlinks in it in the repo checkout, just because test.dart uses
suddenly packages] ....

[Emily Fortuna, 2014-03-06 01:07:04]

lgtm. Glad to see this change; this will make things much nicer. I was
previously trying to avoid changing test_controller.js

Martin, I'm actually in the process of creating a package for browser controller
and such for another reason. I'll keep you in the loop when it's ready for
review. As of now, though, it's staying separate from test.dart since of the
legacy code and such.

[kustermann, 2014-03-06 10:38:09]

Committed patchset #1 manually as r33365 (presubmit successful).