Change tests to use test.py's test_controller.js, cleanup in browser_controller

dart/tools/testing/dart/browser_controller.dart

Index: dart/tools/testing/dart/browser_controller.dart
diff --git a/dart/tools/testing/dart/browser_controller.dart b/dart/tools/testing/dart/browser_controller.dart
index 80b97d057373a43c19e48128be5600e731e1718e..b9f23ef028258f3884ee9df9347ca016b9a663fb 100644
--- a/dart/tools/testing/dart/browser_controller.dart
+++ b/dart/tools/testing/dart/browser_controller.dart
@@ -1420,21 +1420,24 @@ class BrowserTestingServer {
         var parsedData = parseResult(msg);
         if (parsedData) {
           // Only if the JSON was valid, we'll post it back.

[ricow1, 2014/03/05 11:45:54]

only if the JSON is contains all the required parameters we will handle it and
post it back to the test controller

-          var message = parsedData['message'];
-          var isFirstMessage = parsedData['is_first_message'];
-          var isStatusUpdate = parsedData['is_status_update'];
-          var isDone = parsedData['is_done'];
-          if (!isFirstMessage && !isStatusUpdate) {
-            if (!isDone) {
-              alert("Bug in test_controller.js: " +
-                    "isFirstMessage/isStatusUpdate/isDone were all false");
+          if ('message' in parsedData &&
+              'is_first_message' in parsedData &&
+              'is_status_update' in parsedData &&
+              'is_done' in parsedData) {
+            var message = parsedData['message'];
+            var isFirstMessage = parsedData['is_first_message'];
+            var isStatusUpdate = parsedData['is_status_update'];
+            var isDone = parsedData['is_done'];
+            if (!isFirstMessage && !isStatusUpdate) {
+              if (!isDone) {
+                alert("Bug in test_controller.js: " +
+                      "isFirstMessage/isStatusUpdate/isDone were all false");
+              }
+            }
+            if (message) {
+              reportMessage(message, isFirstMessage, isStatusUpdate);
             }

[kustermann, 2014/03/05 10:43:28]

Maybe we should remove the "if" here to support empty messages?

[ricow1, 2014/03/05 11:45:54]

yes - I think we should

           }
-          if (message) {
-            reportMessage(message, isFirstMessage, isStatusUpdate);
-          }
-        } else {
-          reportMessage(msg, msg == 'STARTING', false);
         }
       }