Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: tools/perf/page_sets/long_running_idle_google_cases.py

Issue 1773103002: Replace memory.long_running_idle_gmail with TBM based version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from perezju Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/memory_infra.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/long_running_idle_google_cases.py
diff --git a/tools/perf/page_sets/long_running_idle_google_cases.py b/tools/perf/page_sets/long_running_idle_google_cases.py
index ee3f5c7559a1e5172304be143e58438435698985..9b46f8c2c96948e5f7db9439595ff795a735977a 100644
--- a/tools/perf/page_sets/long_running_idle_google_cases.py
+++ b/tools/perf/page_sets/long_running_idle_google_cases.py
@@ -6,12 +6,19 @@ from telemetry import story
from page_sets import google_pages
+STARTUP_TIME_IN_SECONDS = 2
IDLE_TIME_IN_SECONDS = 100
def _CreateIdlePageClass(base_page_cls):
class DerivedIdlePage(base_page_cls): # pylint: disable=no-init
def RunPageInteractions(self, action_runner):
- action_runner.Wait(IDLE_TIME_IN_SECONDS)
+ action_runner.Wait(STARTUP_TIME_IN_SECONDS)
+ with action_runner.CreateInteraction('Begin'):
+ action_runner.tab.browser.DumpMemory()
+ with action_runner.CreateInteraction('Idle'):
+ action_runner.Wait(IDLE_TIME_IN_SECONDS)
+ with action_runner.CreateInteraction('End'):
+ action_runner.tab.browser.DumpMemory()
return DerivedIdlePage
@@ -39,4 +46,4 @@ class LongRunningIdleGmailBackgroundPageSet(story.StorySet):
archive_data_file='data/long_running_idle_gmail_page.json',
cloud_storage_bucket=story.PARTNER_BUCKET)
self.AddStory(
- _CreateIdleBackgroundPageClass(google_pages.GmailPage)(self))
+ _CreateIdleBackgroundPageClass(google_pages.GmailPage)(self))
« no previous file with comments | « tools/perf/benchmarks/memory_infra.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698