Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: tools/perf/benchmarks/memory_infra.py

Issue 1773103002: Replace memory.long_running_idle_gmail with TBM based version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from perezju Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/memory.py ('k') | tools/perf/page_sets/long_running_idle_google_cases.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/memory_infra.py
diff --git a/tools/perf/benchmarks/memory_infra.py b/tools/perf/benchmarks/memory_infra.py
index 737f9287f05c936196de0bcf80c874fdfe44dfed..e7934e6f6c76dbc449b47d66ee51e22c3226541f 100644
--- a/tools/perf/benchmarks/memory_infra.py
+++ b/tools/perf/benchmarks/memory_infra.py
@@ -10,6 +10,7 @@ from telemetry import benchmark
from telemetry.timeline import tracing_category_filter
from telemetry.web_perf import timeline_based_measurement
from telemetry.web_perf.metrics import memory_timeline
+from telemetry.web_perf.metrics import v8_gc_latency
import page_sets
@@ -43,6 +44,7 @@ class _MemoryInfra(perf_benchmark.PerfBenchmark):
return True
def SetupBenchmarkDefaultTraceRerunOptions(self, tbm_options):
+ # TODO(perezju): Call this function for TBM benchmarks: crbug.com/593678
tbm_options.SetLegacyTimelineBasedMetrics((
memory_timeline.MemoryTimelineMetric(),
))
@@ -115,3 +117,36 @@ class MemoryBenchmarkTop10Mobile(_MemoryInfra):
@classmethod
def Name(cls):
return 'memory.top_10_mobile'
+
+
+# Disabled on reference builds because they don't support the new
+# Tracing.requestMemoryDump DevTools API.
+# For 'reference' see http://crbug.com/540022.
+# For 'android' see http://crbug.com/579546.
+@benchmark.Disabled('reference', 'android')
+class MemoryLongRunningIdleGmailTBM(_MemoryInfra):
+ """Use (recorded) real world web sites and measure memory consumption
+ of long running idle Gmail page """
+ page_set = page_sets.LongRunningIdleGmailPageSet
+
+ def CreateTimelineBasedMeasurementOptions(self):
+ v8_categories = [
+ 'blink.console', 'renderer.scheduler', 'v8', 'webkit.console']
+ memory_categories = 'blink.console,disabled-by-default-memory-infra'
+ category_filter = tracing_category_filter.TracingCategoryFilter(
+ memory_categories)
+ for category in v8_categories:
+ category_filter.AddIncludedCategory(category)
+ options = timeline_based_measurement.Options(category_filter)
+ options.SetLegacyTimelineBasedMetrics([
+ v8_gc_latency.V8GCLatency(),
+ memory_timeline.MemoryTimelineMetric()])
+ return options
+
+ @classmethod
+ def Name(cls):
+ return 'memory.long_running_idle_gmail_tbm'
+
+ @classmethod
+ def ShouldTearDownStateAfterEachStoryRun(cls):
+ return True
« no previous file with comments | « tools/perf/benchmarks/memory.py ('k') | tools/perf/page_sets/long_running_idle_google_cases.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698