X87: [wasm] Int64Lowering of I64Shl on ia32.

X87: [wasm] Int64Lowering of I64Shl on ia32.

  port ddc626e1cf365261fa38cd3b91cbaf8b5e0444b9 (r34546)

  original commit message:
  I64Shl is lowered to a new turbofan operator, WasmWord64Shl. The new
  operator takes 3 inputs, the low-word input, the high-word input, and
  the shift, and produces 2 output, the low-word output and the high-word
  output.

  At the moment I implemented the lowering only for ia32, but I think the
  CL is already big enough. I will add the other platforms in separate
  CLs.

BUG=

Committed: https://crrev.com/8f506ac6a612df733c9b0643d9c18e02b9fe6c8e
Cr-Commit-Position: refs/heads/master@{#34591}

[zhengxing.li, 2016-03-08 07:16:14]

zhengxing.li@intel.com changed reviewers:
+ ahaas@chromium.org, chunyang.dai@intel.com, weiliang.lin@intel.com

[zhengxing.li, 2016-03-08 07:16:15]

PTAL, thanks!

[ahaas, 2016-03-08 07:21:40]

lgtm

[ahaas, 2016-03-08 07:23:40]

https://codereview.chromium.org/1773083002/diff/1/src/x87/macro-assembler-x87.cc
File src/x87/macro-assembler-x87.cc (right):

https://codereview.chromium.org/1773083002/diff/1/src/x87/macro-assembler-x87...
src/x87/macro-assembler-x87.cc:600: void MacroAssembler::PairShl(Register dst,
Register src, uint8_t shift) {
On ia32 I will rename the parameters to "high" and "low" instead of "dst" and
"src", because "dst" and "src" may be misleading. You could rename the
parameters in this CL already.

[zhengxing.li, 2016-03-08 08:08:27]

On 2016/03/08 07:23:40, ahaas wrote:
>
https://codereview.chromium.org/1773083002/diff/1/src/x87/macro-assembler-x87.cc
> File src/x87/macro-assembler-x87.cc (right):
> 
>
https://codereview.chromium.org/1773083002/diff/1/src/x87/macro-assembler-x87...
> src/x87/macro-assembler-x87.cc:600: void MacroAssembler::PairShl(Register dst,
> Register src, uint8_t shift) {
> On ia32 I will rename the parameters to "high" and "low" instead of "dst" and
> "src", because "dst" and "src" may be misleading. You could rename the
> parameters in this CL already.

Thanks, ahaas.

I updated this CL according to your reviews, please help review this CL again,
thanks!

[ahaas, 2016-03-08 08:34:14]

lgtm

[zhengxing.li, 2016-03-08 09:25:23]

On 2016/03/08 08:34:14, ahaas wrote:
> lgtm

Thanks!

[Weiliang, 2016-03-08 13:47:06]

lgtm

[zhengxing.li, 2016-03-08 14:42:12]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2016-03-08 14:42:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1773083002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1773083002/40001

[commit-bot: I haz the power, 2016-03-08 15:01:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-08 15:03:04]

Description was changed from

==========
X87: [wasm] Int64Lowering of I64Shl on ia32.

  port ddc626e1cf365261fa38cd3b91cbaf8b5e0444b9 (r34546)

  original commit message:
  I64Shl is lowered to a new turbofan operator, WasmWord64Shl. The new
  operator takes 3 inputs, the low-word input, the high-word input, and
  the shift, and produces 2 output, the low-word output and the high-word
  output.

  At the moment I implemented the lowering only for ia32, but I think the
  CL is already big enough. I will add the other platforms in separate
  CLs.

BUG=
==========

to

==========
X87: [wasm] Int64Lowering of I64Shl on ia32.

  port ddc626e1cf365261fa38cd3b91cbaf8b5e0444b9 (r34546)

  original commit message:
  I64Shl is lowered to a new turbofan operator, WasmWord64Shl. The new
  operator takes 3 inputs, the low-word input, the high-word input, and
  the shift, and produces 2 output, the low-word output and the high-word
  output.

  At the moment I implemented the lowering only for ia32, but I think the
  CL is already big enough. I will add the other platforms in separate
  CLs.

BUG=

Committed: https://crrev.com/8f506ac6a612df733c9b0643d9c18e02b9fe6c8e
Cr-Commit-Position: refs/heads/master@{#34591}
==========

[commit-bot: I haz the power, 2016-03-08 15:03:05]

Patchset 3 (id:??) landed as
https://crrev.com/8f506ac6a612df733c9b0643d9c18e02b9fe6c8e
Cr-Commit-Position: refs/heads/master@{#34591}