Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1772703002: Add source information to variable declarations in CPS. (Closed)

Created:
4 years, 9 months ago by Johnni Winther
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add source information to variable declarations in CPS. This adds a source mapping to variable declarations in the beginning of a JS function, that points to the start of the corresponding Dart method: foo: function() { var a, b; ^ maps to foo() { ^ R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/7b7cfb66abb5c0795879b4f4bf68f8cec4a1be66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -12 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 4 chunks +8 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 2 chunks +10 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Johnni Winther
4 years, 9 months ago (2016-03-07 14:50:38 UTC) #3
Siggi Cherem (dart-lang)
lgtm!
4 years, 9 months ago (2016-03-07 18:01:23 UTC) #4
Johnni Winther
4 years, 9 months ago (2016-03-09 09:02:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7b7cfb66abb5c0795879b4f4bf68f8cec4a1be66 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698