Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1772703002: Add source information to variable declarations in CPS. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
index cfea55ab65778d5937a52792dcfeb99ef8969315..6b19607f2d4dbd977098aebc5dae7d947c3aa37f 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
@@ -487,7 +487,8 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
sourceInformation:
sourceInformationBuilder.buildImplicitReturn(constructor));
- return irBuilder.makeFunctionDefinition();
+ return irBuilder.makeFunctionDefinition(
+ sourceInformationBuilder.buildVariableDeclaration());
});
}
@@ -738,7 +739,8 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
irBuilder.buildConstructorBodyHeader(getConstructorBodyParameters(body),
getClosureScopeForNode(node));
visit(node.body);
- return irBuilder.makeFunctionDefinition();
+ return irBuilder.makeFunctionDefinition(
+ sourceInformationBuilder.buildVariableDeclaration());
});
}
@@ -781,7 +783,8 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
value: initialValue,
sourceInformation:
sourceInformationBuilder.buildReturn(sendSet.assignmentOperator));
- return irBuilder.makeFunctionDefinition();
+ return irBuilder.makeFunctionDefinition(
+ sourceInformationBuilder.buildVariableDeclaration());
});
}
@@ -952,7 +955,8 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
} else {
visit(node.body);
}
- return irBuilder.makeFunctionDefinition();
+ return irBuilder.makeFunctionDefinition(
+ sourceInformationBuilder.buildVariableDeclaration());
}
/// Builds the IR for creating an instance of the closure class corresponding
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart ('k') | pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698