Issue 17727002: Stop trusting the sign-in process if it manages to navigate to another URL.

Issue 17727002: Stop trusting the sign-in process if it manages to navigate to another URL. (Closed)

Created:
7 years, 6 months ago by Charlie Reis

Modified:
7 years, 6 months ago

Reviewers:
bcwhite, tim (not reviewing)

CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, nasko, noms (inactive)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Stop trusting the sign-in process if it manages to navigate to another URL. BUG=252062 TEST=See bug R=tim@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208589

Patch Set 2 : Add test #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -8 lines)			Patch
M	chrome/browser/signin/signin_browsertest.cc	View	1	6 chunks	+45 lines, -8 lines	0 comments	Download
M	chrome/browser/signin/signin_manager.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/signin/signin_manager.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper.cc	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

Hey Tim-- Here's the fix, which we've tested manually. We're working on putting together a ...

7 years, 6 months ago (2013-06-25 21:02:23 UTC) #1

tim (not reviewing)

https://codereview.chromium.org/17727002/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc File chrome/browser/ui/sync/one_click_signin_helper.cc (right): https://codereview.chromium.org/17727002/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc#newcode994 chrome/browser/ui/sync/one_click_signin_helper.cc:994: void OneClickSigninHelper::DidNavigateMainFrame( I forget how WebContentsObserver works... are we ...

7 years, 6 months ago (2013-06-25 22:39:43 UTC) #3

Charlie Reis

Added a test. https://codereview.chromium.org/17727002/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc File chrome/browser/ui/sync/one_click_signin_helper.cc (right): https://codereview.chromium.org/17727002/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc#newcode994 chrome/browser/ui/sync/one_click_signin_helper.cc:994: void OneClickSigninHelper::DidNavigateMainFrame( On 2013/06/25 22:39:43, timsteele ...

7 years, 6 months ago (2013-06-26 01:25:39 UTC) #4

Charlie Reis

7 years, 6 months ago (2013-06-26 01:36:35 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r208589 (presubmit successful).

Expand Messages | Collapse Messages