FeatureProvider returns std::map instead of vector

FeatureProvider returns std::map instead of vector

To reduce binding time as much as possible, use std::map(O(1)) instead of std::vector(O(n)).

Also, use 'const_iterator' to fix improper usage of 'auto'.

BUG=592537
TEST=Every tests are green.

Committed: https://crrev.com/8477b57a78fa0faf4b0e65c3aaf6cd6f205fee28
Cr-Commit-Position: refs/heads/master@{#379711}

[limasdf, 2016-03-07 15:56:12]

Patchset #2 (id:20001) has been deleted

[limasdf, 2016-03-07 15:56:22]

Patchset #1 (id:1) has been deleted

[limasdf, 2016-03-07 16:16:23]

Description was changed from

==========
FeatureProvider Returns std::map instead of vector to help find value

BUG=
==========

to

==========
FeatureProvider Returns std::map instead of vector to help find value

To reduce binding time as much as possible, taking proper 
feature as O(1).

BUG=592537
TEST=Every tests are green.
==========

[limasdf, 2016-03-07 16:16:23]

limasdf@gmail.com changed reviewers:
+ rdevlin.cronin@chromium.org

[limasdf, 2016-03-07 16:18:27]

Description was changed from

==========
FeatureProvider Returns std::map instead of vector to help find value

To reduce binding time as much as possible, taking proper 
feature as O(1).

BUG=592537
TEST=Every tests are green.
==========

to

==========
FeatureProvider Returns std::map instead of vector to help find value

To reduce binding time as much as possible, taking proper 
feature as O(1).
Also, use 'const_iterator' to fix improper usage of 'auto'.

BUG=592537
TEST=Every tests are green.
==========

[limasdf, 2016-03-07 16:27:31]

When you have time.

Will this be acceptable?
This is not a huge improvement. however, I think we should minimize extension
api binding time as much as we can.

Also I fixed that using 'const_iterator' instead of 'auto'. I apologize for my
uncareful TBRing. http://goo.gl/SQ5Tjh

[Devlin, 2016-03-07 17:35:32]

lgtm, nice change!

https://codereview.chromium.org/1772683002/diff/60001/extensions/common/manif...
File extensions/common/manifest.cc (right):

https://codereview.chromium.org/1772683002/diff/60001/extensions/common/manif...
extensions/common/manifest.cc:149: for (const auto& feature :
manifest_feature_provider->GetAllFeatures()) {
nit: calling this "feature" is a little misleading because it's the key-value
pair in the map.  I'd almost prefer it be called "map_entry" or "feature_kv" or
something like that to indicate it's not a Feature.

[limasdf, 2016-03-08 00:00:53]

Description was changed from

==========
FeatureProvider Returns std::map instead of vector to help find value

To reduce binding time as much as possible, taking proper 
feature as O(1).
Also, use 'const_iterator' to fix improper usage of 'auto'.

BUG=592537
TEST=Every tests are green.
==========

to

==========
FeatureProvider returns std::map instead of vector

To reduce binding time as much as possible, use std::map(O(1)) instead of
std::vector(O(n)).

Also, use 'const_iterator' to fix improper usage of 'auto'.

BUG=592537
TEST=Every tests are green.
==========

[limasdf, 2016-03-08 01:18:20]

Thanks for the review.

https://codereview.chromium.org/1772683002/diff/60001/extensions/common/manif...
File extensions/common/manifest.cc (right):

https://codereview.chromium.org/1772683002/diff/60001/extensions/common/manif...
extensions/common/manifest.cc:149: for (const auto& feature :
manifest_feature_provider->GetAllFeatures()) {
On 2016/03/07 17:35:32, Devlin wrote:
> nit: calling this "feature" is a little misleading because it's the key-value
> pair in the map.  I'd almost prefer it be called "map_entry" or "feature_kv"
or
> something like that to indicate it's not a Feature.

Done.
I used "map_entry" which is more generally being used.

# openlab0 ~/chromium/src/extensions (map)
$> grep map_entry * -rn| wc -l
26
# openlab0 ~/chromium/src/extensions (map)
$> grep _kv * -rn| wc -l
0

[limasdf, 2016-03-08 01:18:39]

The CQ bit was checked by limasdf@gmail.com

[limasdf, 2016-03-08 01:18:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1772683002/#ps80001
(title: "review")

[commit-bot: I haz the power, 2016-03-08 01:18:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772683002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772683002/80001

[commit-bot: I haz the power, 2016-03-08 01:53:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 01:53:45]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[limasdf, 2016-03-08 02:57:49]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2016-03-08 02:58:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1772683002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1772683002/80001

[commit-bot: I haz the power, 2016-03-08 03:04:22]

Description was changed from

==========
FeatureProvider returns std::map instead of vector

To reduce binding time as much as possible, use std::map(O(1)) instead of
std::vector(O(n)).

Also, use 'const_iterator' to fix improper usage of 'auto'.

BUG=592537
TEST=Every tests are green.
==========

to

==========
FeatureProvider returns std::map instead of vector

To reduce binding time as much as possible, use std::map(O(1)) instead of
std::vector(O(n)).

Also, use 'const_iterator' to fix improper usage of 'auto'.

BUG=592537
TEST=Every tests are green.
==========

[commit-bot: I haz the power, 2016-03-08 03:04:23]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-03-08 03:06:09]

Description was changed from

==========
FeatureProvider returns std::map instead of vector

To reduce binding time as much as possible, use std::map(O(1)) instead of
std::vector(O(n)).

Also, use 'const_iterator' to fix improper usage of 'auto'.

BUG=592537
TEST=Every tests are green.
==========

to

==========
FeatureProvider returns std::map instead of vector

To reduce binding time as much as possible, use std::map(O(1)) instead of
std::vector(O(n)).

Also, use 'const_iterator' to fix improper usage of 'auto'.

BUG=592537
TEST=Every tests are green.

Committed: https://crrev.com/8477b57a78fa0faf4b0e65c3aaf6cd6f205fee28
Cr-Commit-Position: refs/heads/master@{#379711}
==========

[commit-bot: I haz the power, 2016-03-08 03:06:10]

Patchset 3 (id:??) landed as
https://crrev.com/8477b57a78fa0faf4b0e65c3aaf6cd6f205fee28
Cr-Commit-Position: refs/heads/master@{#379711}