extensions/common/features/base_feature_provider.h - Issue 1772683002: FeatureProvider returns std::map instead of vector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/base_feature_provider.h

Issue 1772683002: FeatureProvider returns std::map instead of vector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/features/base_feature_provider.h

diff --git a/extensions/common/features/base_feature_provider.h b/extensions/common/features/base_feature_provider.h

index 3b766c8001db2421c1ab355493dc506c5167521d..0d6129234c1e77e9d3e9de3f593de28a5abf8de5 100644

--- a/extensions/common/features/base_feature_provider.h

+++ b/extensions/common/features/base_feature_provider.h

@@ -35,7 +35,7 @@ class BaseFeatureProvider : public FeatureProvider {

Feature* GetParent(Feature* feature) const override;

std::vector<Feature*> GetChildren(const Feature& parent) const override;

- const std::vector<std::string>& GetAllFeatureNames() const override;

+ const FeatureMap& GetAllFeatures() const override;

private:

std::map<std::string, scoped_ptr<Feature>> features_;

« no previous file with comments | « no previous file | extensions/common/features/base_feature_provider.cc » ('j') | no next file with comments »