Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

Issue 1772603002: Addition of Certificate Transparency details to Security panel of DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reacted to comments of Charlie and Mike Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/exported/WebURLResponse.cpp
diff --git a/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp b/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp
index 1766df4cfbb2ab2ed61983fab6b127f41abec122..05be131a4970e092ab3e29e0d66c9e6b6e2c2735 100644
--- a/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp
+++ b/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp
@@ -323,6 +323,9 @@ void WebURLResponse::setSecurityStyle(SecurityStyle securityStyle)
void WebURLResponse::setSecurityDetails(const WebSecurityDetails& webSecurityDetails)
{
+ blink::ResourceResponse::SignedCertificateTimestampList sctList;
+ for (const auto& iter : webSecurityDetails.sctList)
+ sctList.append(static_cast<blink::ResourceResponse::SignedCertificateTimestamp>(iter));
Mike West 2016/06/23 16:32:30 It surprises me a little bit that this works. You'
m_private->m_resourceResponse->setSecurityDetails(
webSecurityDetails.protocol,
webSecurityDetails.keyExchange,
@@ -331,7 +334,8 @@ void WebURLResponse::setSecurityDetails(const WebSecurityDetails& webSecurityDet
webSecurityDetails.certId,
webSecurityDetails.numUnknownScts,
webSecurityDetails.numInvalidScts,
- webSecurityDetails.numValidScts);
+ webSecurityDetails.numValidScts,
+ sctList);
}
ResourceResponse& WebURLResponse::toMutableResourceResponse()

Powered by Google App Engine
This is Rietveld 408576698