Addition of Certificate Transparency details to Security panel of DevTools

third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 305 matching lines @@
     return static_cast<SecurityStyle>(m_private->m_resourceResponse->getSecurityStyle());
 }
 
 void WebURLResponse::setSecurityStyle(SecurityStyle securityStyle)
 {
     m_private->m_resourceResponse->setSecurityStyle(static_cast<ResourceResponse::SecurityStyle>(securityStyle));
 }
 
 void WebURLResponse::setSecurityDetails(const WebSecurityDetails& webSecurityDetails)
 {
+    blink::ResourceResponse::SignedCertificateTimestampList sctList;
+    for (const auto& iter : webSecurityDetails.sctList)
+        sctList.append(static_cast<blink::ResourceResponse::SignedCertificateTimestamp>(iter));

[Mike West, 2016/06/23 16:32:30]

It surprises me a little bit that this works. You're static_casting a
`blink::WebURLRequest::SignedCertificateTimestamp` to
`blink::ResourceResponse::SignedCertificateTimestamp` whose attributes have
different types. Why doesn't that explode?

     m_private->m_resourceResponse->setSecurityDetails(
         webSecurityDetails.protocol,
         webSecurityDetails.keyExchange,
         webSecurityDetails.cipher,
         webSecurityDetails.mac,
         webSecurityDetails.certId,
         webSecurityDetails.numUnknownScts,
         webSecurityDetails.numInvalidScts,
-        webSecurityDetails.numValidScts);
+        webSecurityDetails.numValidScts,
+        sctList);
 }
 
 ResourceResponse& WebURLResponse::toMutableResourceResponse()
 {
     ASSERT(m_private);
     ASSERT(m_private->m_resourceResponse);
 
     return *m_private->m_resourceResponse;
 }
 
@@ skipping 165 matching lines @@
     // Subclasses may call this directly so a self-assignment check is needed
     // here as well as in the public assign method.
     if (m_private == p)
         return;
     if (m_private)
         m_private->dispose();
     m_private = p;
 }
 
 } // namespace blink