Addition of Certificate Transparency details to Security panel of DevTools

chrome/browser/ssl/chrome_security_state_model_client.cc

Index: chrome/browser/ssl/chrome_security_state_model_client.cc
diff --git a/chrome/browser/ssl/chrome_security_state_model_client.cc b/chrome/browser/ssl/chrome_security_state_model_client.cc
index 412b89f3d547af090a0b9c59db8b1fdb7b13c9d1..a14a883af9cbb84a0385a0f9eafe2d32ce3b0a04 100644
--- a/chrome/browser/ssl/chrome_security_state_model_client.cc
+++ b/chrome/browser/ssl/chrome_security_state_model_client.cc
@@ -110,8 +110,13 @@ void ChromeSecurityStateModelClient::GetVisibleSecurityState(
   state->connection_status = ssl.connection_status;
   state->security_bits = ssl.security_bits;
   state->sct_verify_statuses.clear();
-  for (const auto& sct : ssl.signed_certificate_timestamp_ids)
-    state->sct_verify_statuses.push_back(sct.status);
+  int i;

[Eran Messeri, 2016/04/26 09:29:51]

nit: Inline definition of i in the for loop(s).
Even better, std::vector has a variant of insert that allows you to insert
multiple elements, so you could do something like:
state->sct_verify_statuses.insert(state->sct_verify_statuses.begin(),
ssl.num_unknown_scts, net::ct::SCT_STATUS_LOG_UNKNOWN).

[dwaxweiler, 2016/04/28 07:46:19]

Acknowledged.

+  for (i = 0; i < ssl.num_unknown_scts; i++)
+    state->sct_verify_statuses.push_back(net::ct::SCT_STATUS_LOG_UNKNOWN);
+  for (i = 0; i < ssl.num_invalid_scts; i++)
+    state->sct_verify_statuses.push_back(net::ct::SCT_STATUS_INVALID);
+  for (i = 0; i < ssl.num_valid_scts; i++)
+    state->sct_verify_statuses.push_back(net::ct::SCT_STATUS_OK);
   state->displayed_mixed_content =
       (ssl.content_status & content::SSLStatus::DISPLAYED_INSECURE_CONTENT)
           ? true