Addition of Certificate Transparency details to Security panel of DevTools

chrome/browser/ssl/chrome_security_state_model_client.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ssl/chrome_security_state_model_client.h"
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram_macros.h"
 #include "build/build_config.h"
@@ skipping 92 matching lines @@
   state->initialized = true;
   state->url = entry->GetURL();
   const content::SSLStatus& ssl = entry->GetSSL();
   state->initial_security_level =
       GetSecurityLevelForSecurityStyle(ssl.security_style);
   state->cert_id = ssl.cert_id;
   state->cert_status = ssl.cert_status;
   state->connection_status = ssl.connection_status;
   state->security_bits = ssl.security_bits;
   state->sct_verify_statuses.clear();
-  for (const auto& sct : ssl.signed_certificate_timestamp_ids)
-    state->sct_verify_statuses.push_back(sct.status);
+  int i;

[Eran Messeri, 2016/04/26 09:29:51]

nit: Inline definition of i in the for loop(s).
Even better, std::vector has a variant of insert that allows you to insert
multiple elements, so you could do something like:
state->sct_verify_statuses.insert(state->sct_verify_statuses.begin(),
ssl.num_unknown_scts, net::ct::SCT_STATUS_LOG_UNKNOWN).

[dwaxweiler, 2016/04/28 07:46:19]

Acknowledged.

+  for (i = 0; i < ssl.num_unknown_scts; i++)
+    state->sct_verify_statuses.push_back(net::ct::SCT_STATUS_LOG_UNKNOWN);
+  for (i = 0; i < ssl.num_invalid_scts; i++)
+    state->sct_verify_statuses.push_back(net::ct::SCT_STATUS_INVALID);
+  for (i = 0; i < ssl.num_valid_scts; i++)
+    state->sct_verify_statuses.push_back(net::ct::SCT_STATUS_OK);
   state->displayed_mixed_content =
       (ssl.content_status & content::SSLStatus::DISPLAYED_INSECURE_CONTENT)
           ? true
           : false;
   state->ran_mixed_content =
       (ssl.content_status & content::SSLStatus::RAN_INSECURE_CONTENT) ? true
                                                                       : false;
 }