Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 177243012: heap: allow allocation in gc prologue/epilogue (Closed)

Created:
6 years, 9 months ago by indutny
Modified:
6 years, 9 months ago
CC:
v8-dev
Base URL:
gh:v8/v8@master
Visibility:
Public.

Description

heap: allow allocation in gc prologue/epilogue BUG= R=hpayer@chromium.org, danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19978

Patch Set 1 #

Patch Set 2 : added test #

Patch Set 3 : disallow re-entering callbacks #

Total comments: 3

Patch Set 4 : fixes #

Total comments: 2

Patch Set 5 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -25 lines) Patch
M include/v8.h View 1 2 3 4 2 chunks +12 lines, -14 lines 0 comments Download
M src/heap.h View 1 2 3 chunks +15 lines, -0 lines 0 comments Download
M src/heap.cc View 1 2 3 chunks +18 lines, -11 lines 0 comments Download
M src/heap-inl.h View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 3 chunks +53 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
indutny
6 years, 9 months ago (2014-02-25 15:51:47 UTC) #1
danno
Hannes, can you please take a look at this for Fedor?
6 years, 9 months ago (2014-02-25 15:53:39 UTC) #2
Hannes Payer (out of office)
What is the motivation of that change?
6 years, 9 months ago (2014-02-26 09:01:37 UTC) #3
indutny
On 2014/02/26 09:01:37, Hannes Payer wrote: > What is the motivation of that change? In ...
6 years, 9 months ago (2014-02-26 09:07:54 UTC) #4
Hannes Payer (out of office)
This change is a bit scary. I am not a big fan of allocation in ...
6 years, 9 months ago (2014-02-27 15:32:37 UTC) #5
indutny
On 2014/02/27 15:32:37, Hannes Payer wrote: > This change is a bit scary. I am ...
6 years, 9 months ago (2014-02-27 15:55:53 UTC) #6
Hannes Payer (out of office)
It would be nice to keep them in sync. Can you try to write a ...
6 years, 9 months ago (2014-03-03 15:20:12 UTC) #7
indutny
On 2014/03/03 15:20:12, Hannes Payer wrote: > It would be nice to keep them in ...
6 years, 9 months ago (2014-03-05 10:48:49 UTC) #8
indutny
On 2014/03/05 10:48:49, indutny wrote: > On 2014/03/03 15:20:12, Hannes Payer wrote: > > It ...
6 years, 9 months ago (2014-03-05 11:23:10 UTC) #9
Hannes Payer (out of office)
I don't think this is testing the interesting case, i.e., triggering a gc in the ...
6 years, 9 months ago (2014-03-06 08:20:32 UTC) #10
indutny
On 2014/03/06 08:20:32, Hannes Payer wrote: > I don't think this is testing the interesting ...
6 years, 9 months ago (2014-03-06 12:12:39 UTC) #11
indutny
On 2014/03/06 12:12:39, indutny wrote: > On 2014/03/06 08:20:32, Hannes Payer wrote: > > I ...
6 years, 9 months ago (2014-03-10 20:37:14 UTC) #12
Hannes Payer (out of office)
Looking good, I like it! Additionally, could you please add a comment to the corresponding ...
6 years, 9 months ago (2014-03-11 10:57:19 UTC) #13
indutny
On 2014/03/11 10:57:19, Hannes Payer wrote: > Looking good, I like it! > Additionally, could ...
6 years, 9 months ago (2014-03-11 20:43:58 UTC) #14
indutny
On 2014/03/11 20:43:58, indutny wrote: > On 2014/03/11 10:57:19, Hannes Payer wrote: > > Looking ...
6 years, 9 months ago (2014-03-13 16:16:42 UTC) #15
Hannes Payer (out of office)
LGTM, please fix the comments https://codereview.chromium.org/177243012/diff/60001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/177243012/diff/60001/include/v8.h#newcode4132 include/v8.h:4132: * trigger the Garbage ...
6 years, 9 months ago (2014-03-14 08:57:15 UTC) #16
indutny
On 2014/03/14 08:57:15, Hannes Payer wrote: > LGTM, please fix the comments > > https://codereview.chromium.org/177243012/diff/60001/include/v8.h ...
6 years, 9 months ago (2014-03-14 09:42:19 UTC) #17
Hannes Payer (out of office)
Committed patchset #5 manually as r19978 (presubmit successful).
6 years, 9 months ago (2014-03-17 10:38:58 UTC) #18
indutny
6 years, 9 months ago (2014-03-17 10:42:30 UTC) #19
Message was sent while issue was closed.
On 2014/03/17 10:38:58, Hannes Payer wrote:
> Committed patchset #5 manually as r19978 (presubmit successful).

Yaaay! Thank you very much, any chance it could be backported to 3.24?

Powered by Google App Engine
This is Rietveld 408576698