Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1772403003:
usrsctp: Change dependency from //crypto to //third_party/boringssl (Closed)
|
Created:
4 years, 9 months ago by kjellander_chromium Modified:
4 years, 9 months ago CC:
chromium-reviews Base URL:
http://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionusrsctp: Change dependency from //crypto to //third_party/boringssl
This was being added in https://codereview.chromium.org/534713003
but usrsctp should only need BoringSSL since that's what the GYP version
has. Depending on //crypto:platform makes it also depend on //base, which
is something WebRTC (which also uses usrsctp) cannot depend on.
BUG=
Committed: https://crrev.com/ad630b70b3826949d8596b385eeb481243c70bf5
Cr-Commit-Position: refs/heads/master@{#379964}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772403003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== usrsctp: Change dependency from //crypto to //third_party/boringssl This was being added in https://codereview.chromium.org/534713003 but usrsctp should only need BoringSSL since that's what the GYP version has. Depending on //crypto:platform makes it also depend on //base, which is something WebRTC cannot depend (which also uses usrsctp). BUG= ========== to ========== usrsctp: Change dependency from //crypto to //third_party/boringssl This was being added in https://codereview.chromium.org/534713003 but usrsctp should only need BoringSSL since that's what the GYP version has. Depending on //crypto:platform makes it also depend on //base, which is something WebRTC (which also uses usrsctp) cannot depend on. BUG= ==========
kjellander@chromium.org changed reviewers: + brettw@chromium.org
brettw: do you remember if there was specific reason to adding //crypto:platform in your https://codereview.chromium.org/534713003 ?
kjellander@chromium.org changed reviewers: + lally@chromium.org
lally can you approve since brettw is OOO?
On 2016/03/08 22:45:29, kjellander (chromium) wrote: > lally can you approve since brettw is OOO? LGTM
The CQ bit was checked by kjellander@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772403003/1
Message was sent while issue was closed.
Description was changed from ========== usrsctp: Change dependency from //crypto to //third_party/boringssl This was being added in https://codereview.chromium.org/534713003 but usrsctp should only need BoringSSL since that's what the GYP version has. Depending on //crypto:platform makes it also depend on //base, which is something WebRTC (which also uses usrsctp) cannot depend on. BUG= ========== to ========== usrsctp: Change dependency from //crypto to //third_party/boringssl This was being added in https://codereview.chromium.org/534713003 but usrsctp should only need BoringSSL since that's what the GYP version has. Depending on //crypto:platform makes it also depend on //base, which is something WebRTC (which also uses usrsctp) cannot depend on. BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== usrsctp: Change dependency from //crypto to //third_party/boringssl This was being added in https://codereview.chromium.org/534713003 but usrsctp should only need BoringSSL since that's what the GYP version has. Depending on //crypto:platform makes it also depend on //base, which is something WebRTC (which also uses usrsctp) cannot depend on. BUG= ========== to ========== usrsctp: Change dependency from //crypto to //third_party/boringssl This was being added in https://codereview.chromium.org/534713003 but usrsctp should only need BoringSSL since that's what the GYP version has. Depending on //crypto:platform makes it also depend on //base, which is something WebRTC (which also uses usrsctp) cannot depend on. BUG= Committed: https://crrev.com/ad630b70b3826949d8596b385eeb481243c70bf5 Cr-Commit-Position: refs/heads/master@{#379964} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ad630b70b3826949d8596b385eeb481243c70bf5 Cr-Commit-Position: refs/heads/master@{#379964}
Message was sent while issue was closed.
I suspect it had to do with the switching we used to do between NSS and OpenSSL before. The crypto target would use the correct one automatically, but that's all cleaned up now. LGTM |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
