Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 534713003: Add some more libjingle targets to the GN build. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
4 years, 9 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add some more libjingle targets to the GN build. Add usrsctp. Make Windows version configurable for this in the build. direct_dependent_configs for libsrtp. R=hclam@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/c63f22b374dd953b8003800babbe833688e4b93d

Patch Set 1 #

Patch Set 2 : git cl try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -18 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/win/BUILD.gn View 2 chunks +9 lines, -2 lines 0 comments Download
M build/secondary/third_party/libsrtp/BUILD.gn View 1 15 chunks +5 lines, -14 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libjingle/BUILD.gn View 2 chunks +221 lines, -0 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 3 chunks +4 lines, -0 lines 0 comments Download
A third_party/usrsctp/BUILD.gn View 1 chunk +129 lines, -0 lines 0 comments Download
M third_party/usrsctp/usrsctp.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Alpha Left Google
LGTM.
6 years, 3 months ago (2014-09-02 21:53:11 UTC) #2
brettw
Committed patchset #2 (id:20001) manually as c63f22b (presubmit successful).
6 years, 3 months ago (2014-09-02 22:07:32 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:21:03 UTC) #4
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c63f22b374dd953b8003800babbe833688e4b93d
Cr-Commit-Position: refs/heads/master@{#293004}

Powered by Google App Engine
This is Rietveld 408576698