Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: chrome/browser/android/most_visited_sites.h

Issue 1772363002: Start using the whitelist icon on the NTP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/most_visited_sites.h
diff --git a/chrome/browser/android/most_visited_sites.h b/chrome/browser/android/most_visited_sites.h
index 33fdca54eeb2d1351652a93f709cf571f9a64efe..4a44b6badbd079d72ef855b09e766dc7bacb729b 100644
--- a/chrome/browser/android/most_visited_sites.h
+++ b/chrome/browser/android/most_visited_sites.h
@@ -13,6 +13,7 @@
#include "base/android/scoped_java_ref.h"
#include "base/compiler_specific.h"
+#include "base/files/file_path.h"
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
@@ -89,6 +90,8 @@ class MostVisitedSites : public sync_driver::SyncServiceObserver,
base::string16 title;
GURL url;
MostVisitedSource source;
+ // Only valid for source == WHITELIST (empty otherwise).
Bernhard Bauer 2016/03/15 12:03:35 Please add empty lines before comments, to make it
atanasova 2016/03/16 10:55:24 Done.
+ base::FilePath large_icon_path;
// Only valid for source == SUGGESTIONS_SERVICE (-1 otherwise).
int provider_index;
@@ -97,6 +100,10 @@ class MostVisitedSites : public sync_driver::SyncServiceObserver,
MostVisitedSource source);
Suggestion(const base::string16& title,
const GURL& url,
+ MostVisitedSource source,
+ const base::FilePath& large_icon_path);
+ Suggestion(const base::string16& title,
Bernhard Bauer 2016/03/15 12:03:35 Do we really need all of these constructors? Could
atanasova 2016/03/16 10:55:24 Created a builder class
+ const GURL& url,
MostVisitedSource source);
Suggestion(const base::string16& title,
const std::string& url,

Powered by Google App Engine
This is Rietveld 408576698