chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java - Issue 1772363002: Start using the whitelist icon on the NTP.

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

Issue 1772363002: Start using the whitelist icon on the NTP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java ('k') | chrome/browser/android/most_visited_sites.h » ('j') | chrome/browser/android/most_visited_sites.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

index 5a8d04f5e88e3b03d98dfdd0908d8a3ec55515ce..1dd1bfb6dd82e697158034cb0d59b42dc6dc4edf 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java

@@ -48,6 +48,7 @@ public class NewTabPageTest extends ChromeTabbedActivityTestBase {

private static final String TEST_PAGE = "/chrome/test/data/android/navigate/simple.html";

private static final String[] FAKE_MOST_VISITED_TITLES = new String[] { "Simple" };

+ private static final String[] FAKE_MOST_VISITED_LARGE_ICON_PATHS = new String[] {""};

Bernhard Bauer 2016/03/15 12:03:35 Nit: For consistency with the line above, add spac

atanasova 2016/03/16 10:55:24 git cl format keeps removing the spaces. Should I

Bernhard Bauer 2016/03/16 12:14:18 I would. clang-format is more built for C(/C++) th

atanasova 2016/03/16 17:58:17 Done.

private Tab mTab;

private NewTabPage mNtp;

@@ -82,8 +83,9 @@ public class NewTabPageTest extends ChromeTabbedActivityTestBase {

public void run() {

// Create FakeMostVisitedSites after starting the activity, since it depends on

// native code.

- mFakeMostVisitedSites = new FakeMostVisitedSites(mTab.getProfile(),

- FAKE_MOST_VISITED_TITLES, mFakeMostVisitedUrls);

+ mFakeMostVisitedSites =

+ new FakeMostVisitedSites(mTab.getProfile(), FAKE_MOST_VISITED_TITLES,

+ mFakeMostVisitedUrls, FAKE_MOST_VISITED_LARGE_ICON_PATHS);

}

});

} catch (Throwable t) {