Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1772293003: git cl upload: print patchset when uploading to Rietvled. (Closed)

Created:
4 years, 9 months ago by tandrii(chromium)
Modified:
4 years, 9 months ago
Reviewers:
Bons, Paweł Hajdan Jr.
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

git cl upload: print patchset when uploading to Rietvled. R=andybons@chromium.org,phajdan@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299174

Patch Set 1 #

Patch Set 2 : ps2-just-test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/upload.py View 2 chunks +6 lines, -3 lines 2 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
tandrii(chromium)
PTAL Example output: # Creating issue - first patchset $ git cl upload Using 50% ...
4 years, 9 months ago (2016-03-08 18:33:23 UTC) #1
Bons
lgtm https://codereview.chromium.org/1772293003/diff/20001/third_party/upload.py File third_party/upload.py (right): https://codereview.chromium.org/1772293003/diff/20001/third_party/upload.py#newcode2505 third_party/upload.py:2505: assert issue this is meant to be in ...
4 years, 9 months ago (2016-03-08 18:48:22 UTC) #4
tandrii(chromium)
https://codereview.chromium.org/1772293003/diff/20001/third_party/upload.py File third_party/upload.py (right): https://codereview.chromium.org/1772293003/diff/20001/third_party/upload.py#newcode2505 third_party/upload.py:2505: assert issue On 2016/03/08 18:48:22, Bons wrote: > this ...
4 years, 9 months ago (2016-03-08 19:02:47 UTC) #5
Paweł Hajdan Jr.
LGTM
4 years, 9 months ago (2016-03-08 23:53:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772293003/20001
4 years, 9 months ago (2016-03-09 06:59:50 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 07:01:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299174

Powered by Google App Engine
This is Rietveld 408576698