Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4063)

Unified Diff: chrome/browser/android/data_usage/external_data_use_observer_bridge.cc

Issue 1772273002: Remove one thread hop while fetching matching rules (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/data_usage/external_data_use_observer_bridge.cc
diff --git a/chrome/browser/android/data_usage/external_data_use_observer_bridge.cc b/chrome/browser/android/data_usage/external_data_use_observer_bridge.cc
index 63e49661b8afda4599d288df6109992e2e8f4885..dbf3c5eae32fedbf32a1dff9b3bdf87b5aa2f10b 100644
--- a/chrome/browser/android/data_usage/external_data_use_observer_bridge.cc
+++ b/chrome/browser/android/data_usage/external_data_use_observer_bridge.cc
@@ -128,6 +128,10 @@ void ExternalDataUseObserverBridge::FetchMatchingRulesDone(
data_use_tab_model_->RegisterURLRegexes(
app_package_name_native, domain_path_regex_native, label_native);
+
+ io_task_runner_->PostTask(
+ FROM_HERE, base::Bind(&ExternalDataUseObserver::OnFetchMatchingRulesDone,
tbansal1 2016/03/10 01:00:58 Why is this callback needed? This is not preventi
Raj 2016/03/10 02:13:34 This callback updates the last_matching_rules_fetc
+ external_data_use_observer_));
}
void ExternalDataUseObserverBridge::ReportDataUse(
@@ -175,6 +179,15 @@ void ExternalDataUseObserverBridge::OnControlAppInstallStateChange(
data_use_tab_model_->OnControlAppInstallStateChange(is_control_app_installed);
}
+void ExternalDataUseObserverBridge::ShouldRegisterAsDataUseObserver(
+ bool should_register) const {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ io_task_runner_->PostTask(
+ FROM_HERE,
+ base::Bind(&ExternalDataUseObserver::ShouldRegisterAsDataUseObserver,
+ external_data_use_observer_, should_register));
+}
+
bool RegisterExternalDataUseObserver(JNIEnv* env) {
return RegisterNativesImpl(env);
}

Powered by Google App Engine
This is Rietveld 408576698