chrome/browser/android/data_usage/external_data_use_observer_unittest.cc - Issue 1772273002: Remove one thread hop while fetching matching rules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/data_usage/external_data_use_observer_unittest.cc

Issue 1772273002: Remove one thread hop while fetching matching rules (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/data_usage/external_data_use_observer_bridge.cc ('K') | « chrome/browser/android/data_usage/external_data_use_observer_bridge.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/data_usage/external_data_use_observer_unittest.cc

diff --git a/chrome/browser/android/data_usage/external_data_use_observer_unittest.cc b/chrome/browser/android/data_usage/external_data_use_observer_unittest.cc

index 5768b3f5ab0331aec50414919c33b0b3a3181fb9..7185358744196a61b36209eb3e105aade8a7e4a0 100644

--- a/chrome/browser/android/data_usage/external_data_use_observer_unittest.cc

+++ b/chrome/browser/android/data_usage/external_data_use_observer_unittest.cc

@@ -594,6 +594,8 @@ TEST_F(ExternalDataUseObserverTest, DataUseReportTimedOut) {

// Create another ExternalDataUseObserver object.

ReplaceExternalDataUseObserver(variation_params);

+ histogram_tester.ExpectTotalCount(kUMAMatchingRuleFirstFetchDurationHistogram,

+ 0);

// Trigger the control app install, and matching rules will be fetched.

external_data_use_observer()