chrome/browser/android/data_usage/external_data_use_observer.h - Issue 1772273002: Remove one thread hop while fetching matching rules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/data_usage/external_data_use_observer.h

Issue 1772273002: Remove one thread hop while fetching matching rules (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/data_usage/data_use_tab_model_unittest.cc ('K') | « chrome/browser/android/data_usage/data_use_ui_tab_model_unittest.cc ('k') | chrome/browser/android/data_usage/external_data_use_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/data_usage/external_data_use_observer.h

diff --git a/chrome/browser/android/data_usage/external_data_use_observer.h b/chrome/browser/android/data_usage/external_data_use_observer.h

index ec9c92b00aaeb1b6fa4e79f87594ea7c24ff623e..32e48142df506468c34a2edd3d41ac6b18e73468 100644

--- a/chrome/browser/android/data_usage/external_data_use_observer.h

+++ b/chrome/browser/android/data_usage/external_data_use_observer.h

@@ -94,6 +94,7 @@ class ExternalDataUseObserver : public data_usage::DataUseAggregator::Observer {

private:

friend class DataUseTabModelTest;

friend class ExternalDataUseObserverTest;

+ friend class DataUseUITabModelTest;

tbansal1 2016/03/08 18:15:01 alphabetical order.

Raj 2016/03/09 02:27:36 Done.

FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, BufferDataUseReports);

FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, BufferSize);

FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, DataUseReportTimedOut);