Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: chrome/browser/android/data_usage/external_data_use_observer.h

Issue 1772273002: Remove one thread hop while fetching matching rules (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_DATA_USAGE_EXTERNAL_DATA_USE_OBSERVER_H_ 5 #ifndef CHROME_BROWSER_ANDROID_DATA_USAGE_EXTERNAL_DATA_USE_OBSERVER_H_
6 #define CHROME_BROWSER_ANDROID_DATA_USAGE_EXTERNAL_DATA_USE_OBSERVER_H_ 6 #define CHROME_BROWSER_ANDROID_DATA_USAGE_EXTERNAL_DATA_USE_OBSERVER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 void ShouldRegisterAsDataUseObserver(bool should_register); 87 void ShouldRegisterAsDataUseObserver(bool should_register);
88 88
89 // Fetches the matching rules asynchronously. 89 // Fetches the matching rules asynchronously.
90 void FetchMatchingRules(); 90 void FetchMatchingRules();
91 91
92 base::WeakPtr<ExternalDataUseObserver> GetWeakPtr(); 92 base::WeakPtr<ExternalDataUseObserver> GetWeakPtr();
93 93
94 private: 94 private:
95 friend class DataUseTabModelTest; 95 friend class DataUseTabModelTest;
96 friend class ExternalDataUseObserverTest; 96 friend class ExternalDataUseObserverTest;
97 friend class DataUseUITabModelTest;
tbansal1 2016/03/08 18:15:01 alphabetical order.
Raj 2016/03/09 02:27:36 Done.
97 FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, BufferDataUseReports); 98 FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, BufferDataUseReports);
98 FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, BufferSize); 99 FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, BufferSize);
99 FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, DataUseReportTimedOut); 100 FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, DataUseReportTimedOut);
100 #if defined(OS_ANDROID) 101 #if defined(OS_ANDROID)
101 FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, 102 FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest,
102 DataUseReportingOnApplicationStatusChange); 103 DataUseReportingOnApplicationStatusChange);
103 #endif 104 #endif
104 FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, HashFunction); 105 FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, HashFunction);
105 FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, 106 FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest,
106 MatchingRuleFetchOnControlAppInstall); 107 MatchingRuleFetchOnControlAppInstall);
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 base::WeakPtrFactory<ExternalDataUseObserver> weak_factory_; 279 base::WeakPtrFactory<ExternalDataUseObserver> weak_factory_;
279 280
280 DISALLOW_COPY_AND_ASSIGN(ExternalDataUseObserver); 281 DISALLOW_COPY_AND_ASSIGN(ExternalDataUseObserver);
281 }; 282 };
282 283
283 } // namespace android 284 } // namespace android
284 285
285 } // namespace chrome 286 } // namespace chrome
286 287
287 #endif // CHROME_BROWSER_ANDROID_DATA_USAGE_EXTERNAL_DATA_USE_OBSERVER_H_ 288 #endif // CHROME_BROWSER_ANDROID_DATA_USAGE_EXTERNAL_DATA_USE_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698