Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1450)

Unified Diff: chrome/browser/android/data_usage/data_use_tab_model_unittest.cc

Issue 1772273002: Remove one thread hop while fetching matching rules (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/data_usage/data_use_tab_model_unittest.cc
diff --git a/chrome/browser/android/data_usage/data_use_tab_model_unittest.cc b/chrome/browser/android/data_usage/data_use_tab_model_unittest.cc
index 75f7e0b9358abe2b1d3a1b3dd55e9452ebe98d02..1ca71bbf38a1d31d3eae9cedf4566fb385cfd442 100644
--- a/chrome/browser/android/data_usage/data_use_tab_model_unittest.cc
+++ b/chrome/browser/android/data_usage/data_use_tab_model_unittest.cc
@@ -19,6 +19,7 @@
#include "base/test/simple_test_tick_clock.h"
#include "base/time/time.h"
#include "chrome/browser/android/data_usage/data_use_matcher.h"
+#include "chrome/browser/android/data_usage/external_data_use_observer_bridge.h"
#include "chrome/browser/android/data_usage/tab_data_use_entry.h"
#include "components/data_usage/core/data_use_aggregator.h"
#include "components/data_usage/core/data_use_amortizer.h"
@@ -67,14 +68,20 @@ class MockTabDataUseObserver
MOCK_METHOD1(NotifyTrackingEnding, void(SessionID::id_type tab_id));
};
+class TestExternalDataUseObserverBridge
+ : public chrome::android::ExternalDataUseObserverBridge {
+ public:
+ TestExternalDataUseObserverBridge() {}
+ void FetchMatchingRules() const override {}
+ void ShouldRegisterAsDataUseObserver(bool should_register) const override{};
+};
+
} // namespace
namespace chrome {
namespace android {
-class ExternalDataUseObserver;
-
class DataUseTabModelTest : public testing::Test {
public:
DataUseTabModelTest()
@@ -85,9 +92,7 @@ class DataUseTabModelTest : public testing::Test {
base::RunLoop().RunUntilIdle();
data_use_tab_model_.reset(new DataUseTabModel());
data_use_tab_model_->InitOnUIThread(
- content::BrowserThread::GetMessageLoopProxyForThread(
- content::BrowserThread::IO),
- base::WeakPtr<ExternalDataUseObserver>());
+ new TestExternalDataUseObserverBridge());
tbansal1 2016/03/08 18:15:01 Would this not cause memory leak in the test? It s
Raj 2016/03/09 02:27:36 Done.
tick_clock_ = new base::SimpleTestTickClock();

Powered by Google App Engine
This is Rietveld 408576698