Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1772253002: Disable some flakily failing tests under Mac ASAN (Closed)

Created:
4 years, 9 months ago by benwells
Modified:
4 years, 9 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable some flakily failing tests under Mac ASAN TBR=thestig@chromium.org BUG=592880, 592771 Committed: https://crrev.com/f844066a491c02fba7e0fa27faeb0d639d37c5b1 Cr-Commit-Position: refs/heads/master@{#379770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -23 lines) Patch
M third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 23 chunks +30 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
benwells
4 years, 9 months ago (2016-03-08 04:50:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772253002/1
4 years, 9 months ago (2016-03-08 04:50:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 07:07:57 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f844066a491c02fba7e0fa27faeb0d639d37c5b1 Cr-Commit-Position: refs/heads/master@{#379770}
4 years, 9 months ago (2016-03-08 07:09:13 UTC) #6
Lei Zhang
look ok, but probably should be reviewed by a Blink developer.
4 years, 9 months ago (2016-03-16 23:08:29 UTC) #7
benwells
On 2016/03/16 23:08:29, Lei Zhang (OOO) wrote: > look ok, but probably should be reviewed ...
4 years, 9 months ago (2016-03-16 23:09:57 UTC) #8
benwells
4 years, 9 months ago (2016-03-16 23:10:10 UTC) #9
Message was sent while issue was closed. 
On 2016/03/16 23:09:57, benwells wrote:
> On 2016/03/16 23:08:29, Lei Zhang (OOO) wrote:
> > look ok, but probably should be reviewed by a Blink developer.
> 
> this has all been reverted now as the proper fix landed...

(I think)

Powered by Google App Engine
This is Rietveld 408576698