Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp

Issue 1772253002: Disable some flakily failing tests under Mac ASAN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp b/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp
index f2ad8b49c796694e104ba9dc5a7826f853ee4d0d..22cce6cf1c0c7c8d132357fa88e14345c3c46e4d 100644
--- a/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLTextFormControlElementTest.cpp
@@ -168,7 +168,13 @@ void testBoundary(HTMLDocument& document, HTMLTextFormControlElement& textContro
}
}
-TEST_F(HTMLTextFormControlElementTest, WordAndSentenceBoundary)
+// Flakily failing under MAC ASAN. See https://crbug.com/592880.
+#if OS(MACOSX) && defined(ADDRESS_SANITIZER)
+#define MAYBE_WordAndSentenceBoundary DISABLED_WordAndSentenceBoundary
+#else
+#define MAYBE_WordAndSentenceBoundary WordAndSentenceBoundary
+#endif
+TEST_F(HTMLTextFormControlElementTest, MAYBE_WordAndSentenceBoundary)
{
HTMLElement* innerText = textControl().innerEditorElement();
{
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698