Chromium Code Reviews
DescriptionFix Mac views_unittests regressions after r379525
All the BridgedNativeWidgetTest tests, and
NativeWidgetMacTest.NonWidgetParent crash after r379525. The problem is
an inability to obtain the Widget's focus manager when a native focus
change occurs because the test harness doesn't have one at that point.
For BridgedNativeWidgetTest, Widget::Close(..) normally informs the
BridgedNativeWidget that the views::RootView is about to be destroyed,
but this unit test harness doesn't use views::Widgets, so that part
needs to be mocked out.
NativeWidgetMacTest.NonWidgetParent was creating a `child` Widget, which
relies on the FocusManager provided by a parent Widget which wasn't
present.
BUG=591016
TBR=kirr@yandex-team.ru
Committed: https://crrev.com/3436bb5299b3c8becec4c7033c25f3f8c70c5692
Cr-Commit-Position: refs/heads/master@{#379773}
Patch Set 1 #Patch Set 2 : Also fix NativeWidgetMacTest.NonWidgetParent #
Messages
Total messages: 16 (7 generated)
|
||||||||||||||||||||||||||||