Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1772153002: Fix BridgedNativeWidgetTest test crashes after r379525 (Closed)

Created:
4 years, 9 months ago by tapted
Modified:
4 years, 9 months ago
Reviewers:
kirr
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Mac views_unittests regressions after r379525 All the BridgedNativeWidgetTest tests, and NativeWidgetMacTest.NonWidgetParent crash after r379525. The problem is an inability to obtain the Widget's focus manager when a native focus change occurs because the test harness doesn't have one at that point. For BridgedNativeWidgetTest, Widget::Close(..) normally informs the BridgedNativeWidget that the views::RootView is about to be destroyed, but this unit test harness doesn't use views::Widgets, so that part needs to be mocked out. NativeWidgetMacTest.NonWidgetParent was creating a `child` Widget, which relies on the FocusManager provided by a parent Widget which wasn't present. BUG=591016 TBR=kirr@yandex-team.ru Committed: https://crrev.com/3436bb5299b3c8becec4c7033c25f3f8c70c5692 Cr-Commit-Position: refs/heads/master@{#379773}

Patch Set 1 #

Patch Set 2 : Also fix NativeWidgetMacTest.NonWidgetParent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M ui/views/cocoa/bridged_native_widget_unittest.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_mac_unittest.mm View 1 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
tapted
4 years, 9 months ago (2016-03-08 00:49:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772153002/1
4 years, 9 months ago (2016-03-08 00:50:00 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/34712)
4 years, 9 months ago (2016-03-08 01:34:36 UTC) #6
tapted
NativeWidgetMacTest.NonWidgetParent is failing for a similar reason, so I've rolled in a fix fo that ...
4 years, 9 months ago (2016-03-08 02:31:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772153002/20001
4 years, 9 months ago (2016-03-08 07:10:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 07:14:49 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3436bb5299b3c8becec4c7033c25f3f8c70c5692 Cr-Commit-Position: refs/heads/master@{#379773}
4 years, 9 months ago (2016-03-08 07:16:07 UTC) #14
kirr
On 2016/03/08 02:31:10, tapted wrote: > NativeWidgetMacTest.NonWidgetParent is failing for a similar reason, so I've ...
4 years, 9 months ago (2016-03-09 07:15:49 UTC) #15
tapted
4 years, 9 months ago (2016-03-09 07:48:42 UTC) #16
Message was sent while issue was closed.
On 2016/03/09 07:15:49, kirr wrote:
> On 2016/03/08 02:31:10, tapted wrote:
> > NativeWidgetMacTest.NonWidgetParent is failing for a similar reason, so I've
> > rolled in a fix fo that too
> 
> Thanks. I should have run all views_unittests.
> Have you any plans to use trybot for MacViews compilation and tests soon?

Yup - we just need to get all the tests passing (and not flaky) first :). Keep
an eye on http://crbug.com/500806

Powered by Google App Engine
This is Rietveld 408576698