ui/views/cocoa/bridged_native_widget_unittest.mm - Issue 1772153002: Fix BridgedNativeWidgetTest test crashes after r379525

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/cocoa/bridged_native_widget_unittest.mm

Issue 1772153002: Fix BridgedNativeWidgetTest test crashes after r379525 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix NativeWidgetMacTest.NonWidgetParent Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/cocoa/bridged_native_widget_unittest.mm

diff --git a/ui/views/cocoa/bridged_native_widget_unittest.mm b/ui/views/cocoa/bridged_native_widget_unittest.mm

index 5b39b511bc9187d6389b7caa8e98f76880326e90..7723f23851a408303db1f91ab046bdb7170fb285 100644

--- a/ui/views/cocoa/bridged_native_widget_unittest.mm

+++ b/ui/views/cocoa/bridged_native_widget_unittest.mm

@@ -279,6 +279,8 @@ void BridgedNativeWidgetTest::SetUp() {

}

void BridgedNativeWidgetTest::TearDown() {

+ if (bridge())

+ bridge()->SetRootView(nullptr);

view_.reset();

BridgedNativeWidgetTestBase::TearDown();

}

« no previous file with comments | « no previous file | ui/views/widget/native_widget_mac_unittest.mm » ('j') | no next file with comments »