Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1772133002:
GN: add the Android support v17 leanback library target (Closed)
DescriptionGN: add the Android support v17 leanback library target
BUG=592801
Committed: https://crrev.com/9ef2d22bd27a89ccbad09a068182164a14d75fb3
Cr-Commit-Position: refs/heads/master@{#380485}
Patch Set 1 #Patch Set 2 : #
Messages
Total messages: 25 (13 generated)
Description was changed from ========== GYP: add the Android support v17 leanback library target BUG=592801 ========== to ========== GYP: add the Android support v17 leanback library target BUG=592801 ==========
tsunghung@chromium.org changed reviewers: + yusufo@chromium.org
The CQ bit was checked by tsunghung@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772133002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== GYP: add the Android support v17 leanback library target BUG=592801 ========== to ========== GN: add the Android support v17 leanback library target BUG=592801 ==========
lgtm
The CQ bit was checked by tsunghung@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772133002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
tsunghung@chromium.org changed reviewers: + agrieve@chromium.org
Hi Andrew, please help to review this patch, thanks.
On 2016/03/10 17:05:14, AndyWu wrote: > Hi Andrew, please help to review this patch, thanks. lgtm
The CQ bit was checked by tsunghung@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772133002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tsunghung@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1772133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1772133002/20001
Message was sent while issue was closed.
Description was changed from ========== GN: add the Android support v17 leanback library target BUG=592801 ========== to ========== GN: add the Android support v17 leanback library target BUG=592801 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== GN: add the Android support v17 leanback library target BUG=592801 ========== to ========== GN: add the Android support v17 leanback library target BUG=592801 Committed: https://crrev.com/9ef2d22bd27a89ccbad09a068182164a14d75fb3 Cr-Commit-Position: refs/heads/master@{#380485} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9ef2d22bd27a89ccbad09a068182164a14d75fb3 Cr-Commit-Position: refs/heads/master@{#380485} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
