Simplify DefaultAllocator::Quantizer using partitionAllocActualSize()

Simplify DefaultAllocator::Quantizer using partitionAllocActualSize()

Drop QuantizedAllocation completely, and replace with a much simpler
implementation that lets PartitionAlloc just round the allocation size
upwards to fit the nearest bucket.

R=cevans@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167870

[Jens Widell, 2014-02-25 06:59:18]

Next step.  :-)

[Chris Evans, 2014-02-25 07:53:34]

On 2014/02/25 06:59:18, Jens Lindström wrote:
> Next step.  :-)

Wonderful. LGTM.

[Jens Widell, 2014-02-25 07:55:52]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-02-25 07:56:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jl@opera.com/177213007/1

[commit-bot: I haz the power, 2014-02-25 13:26:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jl@opera.com/177213007/1

[commit-bot: I haz the power, 2014-02-25 16:18:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-25 16:18:47]

Retried try job too often on linux_blink for step(s) blink_platform_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[Jens Widell, 2014-02-25 17:34:26]

Had to adjust one (recently added) PurgeableVector test that made assumptions
about the initial capacity of a WTF::Vector which was no longer accurate.

[Philippe, 2014-02-25 17:46:23]

Changes in Source/platform/PurgeableVectorTest.cpp LGTM, thanks!

Out of curiosity, is there/will there be a public equivalent of
QuantizedAllocation::allocationSize()? I was planning to use it in a follow up
CL.

[Philippe, 2014-02-25 17:47:22]

On 2014/02/25 17:46:23, Philippe wrote:
> Changes in Source/platform/PurgeableVectorTest.cpp LGTM, thanks!
> 
> Out of curiosity, is there/will there be a public equivalent of
> QuantizedAllocation::allocationSize()? I was planning to use it in a follow up
> CL.

I meant QuantizedAllocation::quantizedSize() :)

[Chris Evans, 2014-02-25 17:54:23]

On 2014/02/25 17:34:26, Jens Lindström wrote:
> Had to adjust one (recently added) PurgeableVector test that made assumptions
> about the initial capacity of a WTF::Vector which was no longer accurate.

Cool, still LGTM!

[Jens Widell, 2014-02-25 18:07:44]

On 2014/02/25 17:46:23, Philippe wrote:
> Out of curiosity, is there/will there be a public equivalent of
> QuantizedAllocation::allocationSize()? I was planning to use it in a follow up
> CL.

The plan was to drop it in favor of the simpler quantizers that simply reflect
the characteristics of the underlying memory allocator.

But it's not too late to revert the removal of it from this CL, thus leaving it
unused until you start using it. Chris, your opinion on that?

[Chris Evans, 2014-02-25 18:18:36]

On 2014/02/25 18:07:44, Jens Lindström wrote:
> On 2014/02/25 17:46:23, Philippe wrote:
> > Out of curiosity, is there/will there be a public equivalent of
> > QuantizedAllocation::allocationSize()? I was planning to use it in a follow
up
> > CL.
> 
> The plan was to drop it in favor of the simpler quantizers that simply reflect
> the characteristics of the underlying memory allocator.
> 
> But it's not too late to revert the removal of it from this CL, thus leaving
it
> unused until you start using it. Chris, your opinion on that?

I think we should still get rid of it. All Vector and Vector-like buffers should
be allocated out
of the buffer partition. And we now have good partition APIs to handle clients
wanting to quantize.

[Jens Widell, 2014-02-25 18:26:32]

On 2014/02/25 18:18:36, Chris Evans wrote:
> I think we should still get rid of it. All Vector and Vector-like buffers
should
> be allocated out
> of the buffer partition. And we now have good partition APIs to handle clients
> wanting to quantize.

Okay, I'll queue this patch in its current form then. Thanks!

[Jens Widell, 2014-02-25 18:26:42]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-02-25 18:27:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jl@opera.com/177213007/20001

[commit-bot: I haz the power, 2014-02-25 18:49:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-25 18:49:48]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[abarth-chromium, 2014-02-25 18:58:20]

Source/platform LGTM

[Jens Widell, 2014-02-25 18:59:59]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-02-25 19:00:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jl@opera.com/177213007/20001

[commit-bot: I haz the power, 2014-02-25 21:16:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-25 21:16:37]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[Jens Widell, 2014-02-25 21:37:51]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-02-25 21:38:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jl@opera.com/177213007/20001

[commit-bot: I haz the power, 2014-02-25 23:04:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jl@opera.com/177213007/20001

[commit-bot: I haz the power, 2014-02-25 23:23:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jl@opera.com/177213007/20001

[Paweł Hajdan Jr., 2014-02-26 05:45:46]

The CQ bit was unchecked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2014-02-26 06:01:32]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-02-26 06:04:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jl@opera.com/177213007/20001

[commit-bot: I haz the power, 2014-02-26 09:05:44]

Change committed as 167870