Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: Source/wtf/QuantizedAllocation.h

Issue 177213007: Simplify DefaultAllocator::Quantizer using partitionAllocActualSize() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased + adjusted PurgeableVector test Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/wtf/DefaultAllocator.h ('k') | Source/wtf/QuantizedAllocation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/wtf/QuantizedAllocation.h
diff --git a/Source/wtf/QuantizedAllocation.h b/Source/wtf/QuantizedAllocation.h
deleted file mode 100644
index 58c6df2d6009ff3e83079fdaba46d507c806db5f..0000000000000000000000000000000000000000
--- a/Source/wtf/QuantizedAllocation.h
+++ /dev/null
@@ -1,89 +0,0 @@
-/*
- * Copyright (C) 2013 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef WTF_QuantizedAllocation_h
-#define WTF_QuantizedAllocation_h
-
-// DESCRIPTION
-// QuantizedAllocation::quantizedSize() rounds up the specific size such that:
-// 1) Granularity of allocation sizes is >1, and grows as a fraction of the
-// allocation size. This property can be used to limit bucket fragmentation
-// when sitting on top of a high-granularity allocator such as PartitionAlloc.
-// 2) The sizes are likely (but not guaranteed) to correspond to exact "bucket
-// sizes" of any underlying allocator that implements standard bucketing.
-// This currently includes tcmalloc, Windows LFH and PartitionAlloc.
-
-#include "wtf/Assertions.h"
-#include "wtf/WTFExport.h"
-#include <limits.h>
-
-namespace WTF {
-
-class WTF_EXPORT QuantizedAllocation {
-public:
- // Allocations above 32k are rounded to 4k (which is typically the system
- // page size).
- static const size_t kMaxAllocation = 32768;
- static const size_t kMaxRounding = 4096;
-
- // This is the minimum granularity of allocation, currently 8 bytes.
- static const size_t kMinRounding = 8;
-
- // After 128 bytes, the granularity doubles, and proceeds to double again
- // as the allocation size further doubles.
- static const size_t kMinRoundingLimit = 128;
- static const size_t kTableSize = kMaxAllocation / kMinRoundingLimit;
-
- // Using "unsigned" is not a limitation because Chromium's max malloc() is
- // 2GB even on 64-bit.
- static const size_t kMaxUnquantizedAllocation = INT_MAX - kMaxRounding;
-
- static void init();
-
- template<typename T>
- static size_t quantizedSize(size_t count)
- {
- RELEASE_ASSERT(count <= kMaxUnquantizedAllocation / sizeof(T));
- size_t size = count * sizeof(T);
- size_t roundToLessOne;
- if (UNLIKELY(size >= kMaxAllocation))
- roundToLessOne = kMaxRounding - 1;
- else
- roundToLessOne = table[size / kMinRoundingLimit];
- return (size + roundToLessOne) & ~roundToLessOne;
- }
-
-private:
- static unsigned short table[kTableSize];
-};
-
-} // namespace WTF
-
-#endif // WTF_QuantizedAllocation_h
« no previous file with comments | « Source/wtf/DefaultAllocator.h ('k') | Source/wtf/QuantizedAllocation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698