Web Animations CSS: Dispatch all animation events in the animation frame.

Web Animations CSS: Dispatch all animation events in the animation frame.

Previously only events generated during the first timing update for a frame
were fired here and the dispatch mechanism was separate from the
ScriptedAnimationController.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168039

[dstockwell, 2014-02-25 02:02:35]

Depends on https://codereview.chromium.org/135693003/ landing first.

[esprehn, 2014-02-25 02:07:41]

lgtm, awesome, thank you!

[shans, 2014-02-25 03:04:16]

lgtm

[dstockwell, 2014-02-25 09:50:33]

The CQ bit was checked by dstockwell@chromium.org

[commit-bot: I haz the power, 2014-02-25 09:50:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dstockwell@chromium.org/177203009/1

[commit-bot: I haz the power, 2014-02-25 09:51:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-25 09:51:11]

Failed to apply patch for
Source/core/rendering/compositing/RenderLayerCompositor.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/rendering/compositing/RenderLayerCompositor.cpp
  Hunk #1 FAILED at 407.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/rendering/compositing/RenderLayerCompositor.cpp.rej

Patch:       Source/core/rendering/compositing/RenderLayerCompositor.cpp
Index: Source/core/rendering/compositing/RenderLayerCompositor.cpp
diff --git a/Source/core/rendering/compositing/RenderLayerCompositor.cpp
b/Source/core/rendering/compositing/RenderLayerCompositor.cpp
index
3265d4e6cc90eeb8b6d7ade26bc0ceff368e5768..aeecdbf48f238c0894da64b55ae8bb91dd98b95c
100644
--- a/Source/core/rendering/compositing/RenderLayerCompositor.cpp
+++ b/Source/core/rendering/compositing/RenderLayerCompositor.cpp
@@ -407,7 +407,6 @@ void RenderLayerCompositor::updateCompositingLayers()
     lifecycle().advanceTo(DocumentLifecycle::CompositingClean);
 
     DocumentAnimations::startPendingAnimations(m_renderView->document());
-    DocumentAnimations::dispatchAnimationEventsAsync(m_renderView->document());
     ASSERT(document.lifecycle().state() ==
DocumentLifecycle::CompositingClean);
 }

[dstockwell, 2014-02-26 11:12:44]

The CQ bit was checked by dstockwell@chromium.org

[commit-bot: I haz the power, 2014-02-26 11:12:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dstockwell@chromium.org/177203009/20001

[commit-bot: I haz the power, 2014-02-26 13:21:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-26 13:21:45]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[esprehn, 2014-02-26 18:31:22]

Any idea what happened here?

[dstockwell, 2014-02-27 00:09:30]

On 2014/02/26 18:31:22, esprehn wrote:
> Any idea what happened here?

One effect of this change is that the start event for a main-thread animation
now always fires after timing has been updated for the subsequent frame (this
could happen before, but it was rare). Unfortunately many animation tests
weren't written to assume such variance, hence these flaky failures. I will look
at deflaking the affected tests.

[dstockwell, 2014-02-27 13:22:09]

The CQ bit was checked by dstockwell@chromium.org

[commit-bot: I haz the power, 2014-02-27 13:22:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dstockwell@chromium.org/177203009/50001

[commit-bot: I haz the power, 2014-02-27 17:00:36]

Change committed as 168039