Change type of touch selection handles to POPUP

ui/views/touchui/touch_editing_menu.cc

Index: ui/views/touchui/touch_editing_menu.cc
diff --git a/ui/views/touchui/touch_editing_menu.cc b/ui/views/touchui/touch_editing_menu.cc
index 0536e7463964b08fe155c3499eafe731fecd01bc..55c7b804b23a641d6aeb0352e23f57ca2ff0c4f8 100644
--- a/ui/views/touchui/touch_editing_menu.cc
+++ b/ui/views/touchui/touch_editing_menu.cc
@@ -6,6 +6,7 @@
 
 #include "base/strings/utf_string_conversions.h"
 #include "grit/ui_strings.h"
+#include "ui/aura/window.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
@@ -54,6 +55,12 @@ TouchEditingMenuView::TouchEditingMenuView(
       kSpacingBetweenButtons));
   CreateButtons();
   views::BubbleDelegateView::CreateBubble(this);
+  // A transient child is not stacked above its parent upon creation; so, we
+  // do it manually here.
+  // TODO(mohsen): Remove after the above bug is fixed in the transient window
+  // management: crbug.com/352371.
+  GetWidget()->GetNativeView()->parent()->StackChildAbove(
+      GetWidget()->GetNativeView(), context);

[sadrul, 2014/03/14 18:30:07]

What does the fix for this look like? Can we land this fix first?

[mohsen, 2014/03/14 19:15:25]

 2014/03/14 18:30:07, sadrul wrote:
There is a TransientWindowManager::OnChildStackingChanged(child) method that
restacks transient children of child properly. The simplest fix would be to use
this method after a window has become transient child of another one
(TransientWindowManager::AddTransientChild()) or when a window that is the
transient child of another one is added to the windows hierarchy (when a
transient child is created, this one needs OnChildStackingChanged() to be public
to be accessible from Window::AddChild() or a similar method). This seems a bit
ugly and also inefficient and maybe a better solution is needed.

   GetWidget()->Show();
 }